1678860 - Bookmarks are not fully fill Library bookmark right panel after landing patch from bug #1678523

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/message/reply/question/etc.)]

Attachment: screencast.mp4

STR:

1. Start Firefox
2. Open Library
3. Have that amount of bookmarks in one folder which will exceed half of Library panel
4. Notice that bookmarks do not fully fill Library bookmark right panel

Comment 1

[Marco Bonardo [:mak]]

hm, it sounds like a regression from bug 1678523, strange I didn't see it locally

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/message/reply/question/etc.)]

Yes, mozregression-gui pointing me to:

Found commit message: Bug 1678523 - Remove XUL decks from browser/components/places/content/places.xhtml. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D97722

Comment 3

[Tim Nguyen :ntim]

Attachment: Bug 1678860 - Fix downloads view showing when initially opening places view. r=mak

Comment 4

[Tim Nguyen :ntim]

(In reply to Marco Bonardo [:mak] from comment #1)

hm, it sounds like a regression from bug 1678523, strange I didn't see it locally

Yeah, when you have the places view selected initially, the download view will not be hidden, because no code does it.

However, if the downloads view is selected initially, things work fine.

Also, if you switch from the places view to the downloads view then back to the places view, things work fine too.

Comment 5

[Marco Bonardo [:mak]]

At this point, since 1678523 has been backed out, it makes sense to merge the patches.

Comment 6

[Timea Cernea [:tbabos][inactive]]

Reproduced the issue on affected Nightly 85.0a1 (220-11-21) on Windows 10 x64. Verified-fixed on Windows 10 x64 and macOS 10.15 on the latest Nightly 86.0a1 (2020-12-22) (64-bit) and Beta 85.0b4.

Comment 7

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/message/reply/question/etc.)]

As OP, I'm also confirming that bug is fixed, starting in Mozilla Firefox Nightly 85.0a1 (2020-11-27).
Thank you very much! \o/