16789 - [dogfood] apprunner -edit brings up browser window

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, defect, P3)

Description

[Akkana Peck]

As of this morning I'm seeing a sidebar on the editor window as well as the
browser window.  The editor shouldn't have a sidebar by default.

Comment 1

[Akkana Peck]

I misinterpreted the problem; the real problem is that apprunner -edit no longer
works in today's build!  It brings up a browser window.  I'm looking into what
changed.

Comment 2

[Akkana Peck]

Looks like Bill Law was in the arg-parsing code yesterday ...

Comment 3

[Bill Law]

Yes, I was in the arg-parsing code, which was an extremely unfortunate
coincidence (sort of).

I changed the way -edit works so that it no longer uses the verboten "toolkit
app core."  This was working fine at some point in the not too distant past,
when I was doing more exhaustive testing of all the various and sundry window
opening code that was undergoing change.

So I finally checked this code in yesterday.  In the interim (subsequent to my
testing) it turns out some pork-jockeying has caused the hidden window to not be
in a state capable of opening a dialog (its mDocument is 0).

I must now talk to danm and others to figure out how to get out of this
predicament.

Comment 4

[Bill Law]

I've just checked in a fix for this.  Updated files are
mozilla/caps/src/nsScriptSecurityManager.cpp and
mozilla/dom/src/base/nsGlobalWindow.cpp.

Comment 5

[Paul MacQuiddy]

verified, composer is sidebarless with 10/28 builds