1678924 - video on twitter is black with HD3000 on win7 WebRender (no gpu process)

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

This is similar to bug 1678903 except all video seems to black. i.e. even the working videos like https://twitter.com/Twitter/status/1288540609310056450 are black.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1678924. Lower switch to if-else chain.

It looks we hit the same gen6 compiler bug as we did in bug
1663344.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2d438ba2bdd
Lower switch to if-else chain. r=mattwoodrow,jnicol

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9189884 [details]
Bug 1678924. Lower switch to if-else chain.

Beta/Release Uplift Approval Request

• User impact if declined: Some video will not show up for gen6 Intel users.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Very low risk. Just changing the shader from a switch to an if.
• String changes made/needed:

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Gah, this was the wrong bug...

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b2d438ba2bdd

Comment 6

[Ryan VanderMeulen [:RyanVM]]

I assume we want to wait on uplifting this until bug 1679700 is ready as well? Also, are we doing any audits for other possibly-problematic switch statements given that we've hit this driver bug a couple times now?

Comment 7

[Jeff Muizelaar [:jrmuizel]]

Yes, uplifting will need to wait on bug 1679700. I have done a brief audit of other problematic switch statement and nothing jumped out. I'll double check though.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9189884 [details]
Bug 1678924. Lower switch to if-else chain.

Approved for 84.0b7.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4e5820155d65