1679002 - Window for importing key is too small (not scrollable)

Status: NEW

(MailNews Core :: Security: OpenPGP, defect)

Description

[Hoffmann.P]

Attachment: Window is too small

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/87.0.4280.66 Safari/537.36

Steps to reproduce:

Import a long list of private keys

Actual results:

The resulting window could not be resized (b/c of the boxes in it I assume) and was to long to hit OK.

Expected results:

Either
a) scrollable
b) resizeable

Comment 1

[Alessandro Castellani [:aleca]]

Thank you so much for the report.
That list should indeed be scrollable, and also the checkboxes should all be properly aligned and better handle long strings.
Thanks for the screenshot.

As a temporary workaround, you can import your private keys by using the Add Key > Import an OpenPGP Key option.

I suspect you used the Key Manager as I see a closing icon and a window decoration.
That whole section indeed doesn't scale well at all.

Comment 2

[dnk089]

I do not know if this is connected, but I found a similar bug on TB 78.7.2 Daily on Debian 10.

When clicking the OpenPGP button at the right side of the header of a message that was sent to a bunch of recipients, I can only see the first 6 recipients. The popup window does not show a scroll bar to see all recipients., see sceenshot.

Comment 3

[dnk089]

Attachment: TB_78.7.2_OpenPGP_Aliases_MessageSecurityInfo-20210211_22-35-32.png

Comment 4

[dnk089]

As described by Clemens Hanel on https://bugzilla.mozilla.org/show_bug.cgi?id=1644085#c80, this does not occur on Arch with i3 at least.

Comment 5

[Kai Engert (:KaiE:)]

that's a different window.

What is "arch with i3" ?

Comment 6

[dnk089]

(In reply to Kai Engert (:KaiE:) from comment #5)

that's a different window.

What is "arch with i3" ?

I guess: Arch Linux on a machine with Intel I3 processor

Comment 7

[WaltS48 [:walts48]]

(In reply to dnk089 from comment #2)

I do not know if this is connected, but I found a similar bug on TB 78.7.2 Daily on Debian 10.

Arch Linux has an 78.7.2 Daily version?

I'll believe 87.0a1.

Comment 8

[dnk089]

(In reply to WaltS48 [:walts48] from comment #7)

(In reply to dnk089 from comment #2)

I do not know if this is connected, but I found a similar bug on TB 78.7.2 Daily on Debian 10.

Arch Linux has an 78.7.2 Daily version?

I'll believe 87.0a1.

Don't know. I think he used the binary supplied by Kai Engert (:KaiE:) in https://bugzilla.mozilla.org/show_bug.cgi?id=1644085#c77

Btw: I opened another ticket for the issue mentioned above (https://bugzilla.mozilla.org/show_bug.cgi?id=1679002#c2 ) here:
https://bugzilla.mozilla.org/show_bug.cgi?id=1692497

Comment 9

[Martin Mokrejs]

Also the Key importing window is lacks a horizontal scroll bar (my comment line with the key is too wide). I also could not import my own GPG key directly, I had to export it from GNUPG manually and import from a file:

gpg --export-secret-keys --armor $KEYNUM > $KEYNUM.key

I spent half an hour myself trying to import a PGP key into Thunderbird 78.9.0 . I needed to add another email identity to the private key and also, I had to assign it to the trust level 5. Only after both steps I could actually import the key. Before that, I could seemingly import it, a fat green bar showing the key was imported was shown, but no key details were visible in the account details. Thunderbird should have checked that and report a trust issue.

Also, I haven't seem any OK button to press during the import process, my commnet line is too line so the text continues somewhere outside of the tiny Thumnderbirds window. Luckily, pressing blindly enter hits the OK button or however it is called.

Make sure to follow these steps :
https://coderwall.com/p/tx_1-g/gpg-change-email-for-key-in-pgp-key-servers

Comment 10

[Alessandro Castellani [:aleca]]

Did you try to import the key without using the OpenPGP Key Manager?
Add Key > Import an OpenPGP Key option in the Account Settings > End-to-End Encryption section.

The dialogs that open from the Key manager are temporary and will be replaced soon.

Comment 11

[Martin Mokrejs]

It is exactly the way I used. It cannot extract the key on its own from $HOME/.gnupg/ repo, I had to do the above. so, it does not really work. Evidently, it checks for email address associated with the key, decrypts it, show a successfull import message but in practice, does not import it. It wrong. Also, forcing me to add another 'userid' to the key *ucks. Let me import whatver key I have and just attach it to my mail account.

BTW, the import window allows by default to view only GnuPG files but it does not show what file extension they are supposed to have.

Comment 12

[Alessandro Castellani [:aleca]]

What you're describing seems like a whole completely different issue.
This bug is uniquely to track the issue with the import dialog being too small when importing multiple keys.

Kai, are you aware of the issues reported in comment 11 and comment 9?

Comment 13

[Nickolay Olshevsky]

JFYI, it was cross-posted to the https://bugzilla.mozilla.org/show_bug.cgi?id=1668932 and https://bugzilla.mozilla.org/show_bug.cgi?id=1678933

Comment 14

[Kai Engert (:KaiE:)]

So it seems there are multiple issues being discussed here.

First, when a file with many keys is being imported, the window is high, doesn't scrolle, and the keys at the bottom cannot be seen, and the OK button isn't visible. Is this a correct summary of Hoffmann's report?

In my opinion, the dialog should be implemented in a way to have a scrollable region for the middle list of keys - and the button should be outside the scrollable area. Alessandro, is that possible to do?

I have a memory that we you had already worked on that issue. Is it possible that bug is already fixed?

If anyone wants us to help reproducing and testing this issue, you could use a fresh profile, with a fake email address, and create 20-30 secret keys, then backup them all to a combined file, and attach the file with the test private keys there. Then anyone could simply use that test file to reproduce and test this bug.

The second complaint from comment 2 is for a different window. I'm pretty sure that we have alread fixed dnk's issue in another bug.

Third, we have Martin's first complaint. If the name is very long (for example because there is a long comment used), then the window gets very wide, and also more information is cut off.

Alessandro, IMHO all dynamic text should wrap.

Fourth, we have Martin's second issue. Martin, it seems you have added comments to multiple bugs, in each complainint about the same issue. That's confusing. Please remember to file a new separate, when you are reporting an issue that is different. In your scenario, you are complaining that your key cannot be imported. It's not clear to me why it couldn't be imported. It also seems that you might draw an incorrect conclusion. You mention a GPG trust level being set. But that should be irrelevant for Thunderbird importing. So, if you still have an issue, please file a separate bug, so we can avoid confusion, and have separate discussion for different problems. I'm trying to guess what your problem is. I think you had a key for email adress A, but your thunderbird account was for email address B. You imported the key, but Thunderbird didn't offer you to use it for account B. Then you edited your key, added a user ID with email address B, imported that, and then Thunderbird allowed you to use it for thunderbird account B. That's expected behavior currently, we require those to match.

Comment 16

[Alessandro Castellani [:aleca]]

Is this still happening?