Closed Bug 1679029 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26616 - [WebNFC] Remove unused CancelAllWatches

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox85 fixed)

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26616 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26616
Details from upstream follow.

b'Francois Beaufort <beaufort.francois@gmail.com>' wrote:

[WebNFC] Remove unused CancelAllWatches

This CL removes the unused method CancelAllWatches() that used to cancel
all watch NFC operations.

Change-Id: I1a702cae22b7525a9229da818bec91255a273f4b
Bug: 520391

Reviewed-on: https://chromium-review.googlesource.com/2554575
WPT-Export-Revision: 0447d5e93c93eefa3fc2f0593793421f3138e6c2

PR 26616 applied with additional changes from upstream: b9a7ffca3b50041dca273fb45eeb9aad931c1171
PR 26616 applied with additional changes from upstream: 77f3f1533681dedef98a4c94c2abdb562d097002, 7baacba58142ed430f83164c1af0a97a2724b724

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 17 subtests

Status Summary

Firefox

FAIL : 17
ERROR : 1

Chrome

PASS : 11
FAIL : 1
TIMEOUT: 2
NOTRUN : 4

Safari

FAIL : 17
ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/web-nfc/NDEFReader_scan.https.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: TIMEOUT, Safari: ERROR)
Test that NDEFReader.scan rejects if signal is not an AbortSignal.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader.scan should fail if user permission is not granted.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader.scan should fail if no implementation for NFC Mojo interface.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader.scan should fail if NFC HW is disabled.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader.scan should fail if NFC HW is not supported.: FAIL (Chrome: PASS, Safari: FAIL)
Test that WebNFC API is not accessible from iframe context.: FAIL (Chrome: FAIL, Safari: FAIL)
Test that nfc watch success if NFC HW is enabled.: FAIL (Chrome: PASS, Safari: FAIL)
Test that NDEFReader.scan rejects if NDEFScanOptions.signal is already aborted.: FAIL (Chrome: PASS, Safari: FAIL)
Test that NDEFReader.scan rejects if NDEFScanOptions.signal aborts right after the scan invocation.: FAIL (Chrome: PASS, Safari: FAIL)
Test that NDEFReader can not get any reading events once the signal aborts.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFRecord.toRecords returns its embedded records correctly.: FAIL (Chrome: PASS, Safari: FAIL)
NDEFReader.scan returns smart-poster record correctly.: FAIL (Chrome: PASS, Safari: FAIL)
Test that NDEFReader.onreadingerror should be fired if the NFC tag does not expose NDEF technology.: FAIL (Chrome: TIMEOUT, Safari: FAIL)
Test that NDEFReader.onreading should be fired on an unformatted NFC tag with empty records array for NDEFMessage.: FAIL (Chrome: NOTRUN, Safari: FAIL)
Test that reading message with multiple records should succeed.: FAIL (Chrome: NOTRUN, Safari: FAIL)
Test that NDEFReader.scan rejects if there is already an ongoing scan.: FAIL (Chrome: NOTRUN, Safari: FAIL)
Test that NDEFReader.scan can be started after the previous scan is aborted.: FAIL (Chrome: NOTRUN, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/web-nfc/NDEFReader_scan.https.html: ERROR [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: TIMEOUT, Safari: ERROR)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ec05e752c1f9 [wpt PR 26616] - [WebNFC] Remove unused CancelAllWatches, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/52af7a7203f1 [wpt PR 26616] - [WebNFC] Remove unused CancelAllWatches, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.