1679096 - Async support for Localization in rust

Status: RESOLVED DUPLICATE of bug 1613705

(Core :: Internationalization, task, P3)

Description

[u480271]

This is the async part of Bug 1613705 and builds upon those patches.

Comment 1

[u480271]

Attachment: Bug 1679096 - P1: Address code nitpicks. r?zbraniecki

Resulting from running ./mach lint --warnings --outgoing

Comment 2

[u480271]

Attachment: Bug 1679096 - P2: Reformat fluent-ffi. r?zbraniecki

Depends on D97902

Comment 3

[u480271]

Attachment: Bug 1679096 - P3: Update Localization2 to resolve Promise from Rust. r?nika,zbraniecki

For the async methods, resolve promise from Rust. Still using the sync versions
to format values and messages.

Depends on D97905

Comment 4

[u480271]

Attachment: Bug 1679096 - P4: Implement async loading support for Localization2. r?zbraniecki

Depends on D97906

Comment 5

[u480271]

Attachment: Bug 1679096 - P5: Enable construction of async or sync Localization2. r?zbraniecki

Depends on D97907

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Can you provide a try run with all the necessary patches applied? that way I can make sure that the suggestions I provide in reviews actually work.

Comment 7

[Zibi Braniecki [:zbraniecki][:gandalf]]

The current best way is to:

1. Take mozilla-central
2. Apply bug 1679095 (D97904)
3. Apply bug 1679094 (D97905)
4. Apply bug 1613705 (D91709) (that WIP includes all the patches from this review stack, we keep them here to make reviewing easier for you)

Build, launch and you should be able to execute this in a browser console:

(async () => {
let start = performance.mark("loc-start");
let loc = new Localization([
"branding/brand.ftl",
"browser/branding/brandings.ftl",
"browser/branding/sync-brand.ftl",
"browser/preferences/preferences.ftl",
"browser/preferences/fonts.ftl",
"toolkit/featuregates/features.ftl",
"browser/preferences/addEngine.ftl",
"browser/preferences/blocklists.ftl",
"browser/preferences/clearSiteData.ftl",
"browser/preferences/colors.ftl",
"browser/preferences/connection.ftl",
"browser/preferences/languages.ftl",
"browser/preferences/permissions.ftl",
"browser/preferences/selectBookmark.ftl",
"browser/preferences/siteDataSettings.ftl",
"browser/aboutDialog.ftl",
"browser/sanitize.ftl",
"toolkit/updates/history.ftl",
"security/certificates/deviceManager.ftl",
"security/certificates/certManager.ftl",
]);


let values = await loc.formatMessages([{id: "community-2"}]);
let end = performance.mark("loc-end");
//console.log(values);
performance.measure("localization", "loc-start", "loc-end");
console.dir(performance.getEntriesByName("localization").map((e) => e.duration));
})()

where Localization2 is using Rust, and Localization is using JSMs.

Comment 8

[Zibi Braniecki [:zbraniecki][:gandalf]]

This work is now incorporated into WIP patches in bug 1613705.

I'm going to close it in favor of that.