Closed Bug 1679252 Opened 5 years ago Closed 3 years ago

2.73 - 12.17% sessionrestore / startup_about_home / ts_paint (linux64-shippable-qr, windows10-64-shippable, windows10-64-shippable-qr) regression on push cd968a98082773eeccd9bd27b86fde0b0f94971b (Thu November 19 2020)

Categories

(Toolkit Graveyard :: OS.File, defect)

Product:
Toolkit Graveyard
Component:
OS.File
Version:
Firefox 85
Type:
defect

Tracking

(firefox-esr78 unaffected, firefox83 unaffected, firefox84 unaffected, firefox85 fixed)

Status:
RESOLVED WONTFIX
Milestone:
85 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- unaffected
firefox83 --- unaffected
firefox84 --- unaffected
firefox85 --- fixed

People

(Reporter: alexandrui, Unassigned)

References

(Regression)

Details

(4 keywords)

Perfherder has detected a talos performance regression from push cd968a98082773eeccd9bd27b86fde0b0f94971b. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Suite Test Platform Options Absolute values (old vs new)
12% ts_paint_webext ts_paint_webext windows10-64-shippable e10s stylo 371.83 -> 417.08
11% ts_paint_webext ts_paint_webext windows10-64-shippable-qr e10s stylo webrender 380.75 -> 424.00
10% ts_paint ts_paint windows10-64-shippable-qr e10s stylo webrender 383.58 -> 423.08
9% ts_paint_webext ts_paint_webext windows10-64-shippable-qr e10s stylo webrender 390.88 -> 426.00
9% ts_paint ts_paint windows10-64-shippable e10s stylo 379.50 -> 413.00
9% startup_about_home_paint_realworld_webextensions startup_about_home_paint_realworld_webextensions windows10-64-shippable e10s stylo 522.25 -> 568.25
3% sessionrestore sessionrestore linux64-shippable-qr e10s stylo webrender 707.42 -> 726.75

Improvements:

Ratio Suite Test Platform Options Absolute values (old vs new)
34% tp5n nonmain_startup_fileio windows10-64-shippable e10s stylo 2,137,573.71 -> 1,415,973.25
28% tp5n nonmain_startup_fileio windows10-64-shippable-qr e10s stylo webrender 1,952,964.33 -> 1,403,431.75
22% about_newtab_with_snippets responsiveness linux64-shippable-qr e10s stylo webrender 0.21 -> 0.16
14% ts_paint ts_paint linux64-shippable e10s stylo 213.08 -> 182.42
14% ts_paint_webext ts_paint_webext linux64-shippable e10s stylo 213.25 -> 183.50
14% ts_paint ts_paint linux64-shippable-qr e10s stylo webrender-sw 232.75 -> 200.58
13% ts_paint_webext ts_paint_webext linux64-shippable-qr e10s stylo webrender-sw 232.00 -> 201.17
12% ts_paint ts_paint linux64-shippable-qr e10s stylo webrender 248.75 -> 219.25
12% ts_paint_webext ts_paint_webext linux64-shippable-qr e10s stylo webrender 248.58 -> 219.17
3% startup_about_home_paint startup_about_home_paint linux64-shippable-qr e10s stylo webrender-sw 687.83 -> 666.00
3% startup_about_home_paint startup_about_home_paint linux64-shippable e10s stylo 653.50 -> 633.17

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Flags: needinfo?(michael)
Component: Performance → OS.File
Product: Testing → Toolkit

How can I help with this? I've worked on some patches, including this with emalysz her help, so possibly she knows more about this, I'm not that familiar with the working of the code and the effects on performance.
I welcome ideas on how we can improve this, all I did was move from OS.File over to IOUtils and PathUtils with this patch.

Flags: needinfo?(michael) → needinfo?(emalysz)

Set release status flags based on info from the regressing bug 1649590

status-firefox83: --- → unaffected
status-firefox84: --- → unaffected
status-firefox-esr78: --- → unaffected

Update: since it's a holiday week for the people that I worked with on this bug, I've requested a backout so next week we can take our time to look at this.

alex: could you confirm this was resolved by the backout?

Flags: needinfo?(aionescu)

(In reply to Dave Hunt [:davehunt] [he/him] ⌚GMT from comment #4)

alex: could you confirm this was resolved by the backout?

Yes, it was resolved by backout.

Flags: needinfo?(aionescu)
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Assignee: nobody → michael
status-firefox85: affected → fixed
Flags: needinfo?(emalysz)
Target Milestone: --- → 85 Branch

I am not sure why that hasn't improved. The culprit patch was backed-out. I did a backfill, probably the cause of the regression for this test is another patch.

Flags: needinfo?(aionescu)

Note to self

Flags: needinfo?(aionescu)
Status: RESOLVED → REOPENED
Flags: needinfo?(aionescu)
Resolution: FIXED → ---

Seems like the backout from november was mixed up with the regression of the latest push. I apologize,

Flags: needinfo?(aionescu)
Flags: needinfo?(aionescu)

What's the plan with this?
Since now I'm not sure if I caused it with my patch (it was backed out) or not, as per the above.

I'm not sure if I caused it with my patch (it was backed out) or not, as per the above comments, so what should/is going to happen?

Flags: needinfo?(aionescu)

Yeah, seems like ts_paint_webext were caused by Alert 29433. For the other alerts I triggered a backfill to double check the culprit.

You can ignore the alert in comment9. The linux64 machines were retired and replaced with linux1804-64. I attempted to backfill the jobs in the interval, but I can't because there's no linux64-shippable machines available.

Flags: needinfo?(aionescu)

Just to get back to this again, did we find out if I caused it again or not?

Has Regression Range: --- → yes
Assignee: mgoossens → nobody
Status: REOPENED → RESOLVED
Closed: 5 years ago → 3 years ago
Resolution: --- → WONTFIX
Product: Toolkit → Toolkit Graveyard
You need to log in before you can comment on or make changes to this bug.