Closed
Bug 1679293
Opened 5 years ago
Closed 5 years ago
Remove dead code in CheckHasNoSuchProperty and unused parameter LIRGeneratorShared::buildSnapshot
Categories
(Core :: JavaScript Engine: JIT, task, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
85 Branch
| Tracking | Status | |
|---|---|---|
| firefox85 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(2 files)
No description provided.
|
Assignee | |
Comment 1•5 years ago
|
||
CheckHasNoSuchOwnProperty() now always returns false for non-native objects,
which means the if-condition in CheckHasNoSuchProperty() is always false.
Drive-by fixes:
- Return early in
CheckHasNoSuchOwnProperty()for non-native objects. - Update a comment in
tryAttachDoesNotExist().
|
|
Assignee | |
Comment 2•5 years ago
|
||
Depends on D97968
|
||
Updated•5 years ago
|
Severity: -- → N/A
Priority: -- → P3
Pushed by btara@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dc62b47dacc6
Part 1: Remove dead if-statement in CheckHasNoSuchProperty. r=iain
https://hg.mozilla.org/integration/autoland/rev/e99653ed0ba2
Part 2: Remove an unused parameter from LIRGeneratorShared::buildSnapshot(). r=iain
|
||
Comment 4•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dc62b47dacc6
https://hg.mozilla.org/mozilla-central/rev/e99653ed0ba2
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•