1679313 - Take a screenshot option is missing in a frame

Status: RESOLVED FIXED

(Firefox :: Screenshots, defect, P3)

Description

[Martijn]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:83.0) Gecko/20100101 Firefox/83.0

Steps to reproduce:

Right click on an empty bit of a page to select "Take a screenshot".

Actual results:

The whole option is missing, because I happen to right-click in a frame.

Expected results:

There's no reason for "Take a screenshot" to be missing when right-clicking in a frame. This is especially bad when a page consists of one giant page-filling iframe - this will basically destroy the screenshot function.

The option also isn't anywhere in the classic menu, not in the hamburger menu, nor does it have a keyboard shortcut. The context menu is literally the only way to get to the screenshotting function, and that option doesn't work in a frame.

Please note that in the user's perspective, they don't care if something happens to be a frame, and they certainly can't recognize one. Firefox should not arbitrarily hide functions that are page-wide (like screenshot).

Comment 1

[Martijn]

And I still can't correct a bloody typo in my report above. Wow.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 3

[Emma Malysz]

Hey Martijn, thanks for reporting this!

Do you mind providing an example of a website where this problem occurs?

Comment 4

[Martijn]

Sure, here's one example:
https://next--storybookjs.netlify.app
In case you're unfamiliar with Storybook, the Canvas pane is one giant iframe, and you will not get the screenshot option in the context menu there.

But in general the menu item is missing on any iframe, not just that one.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:emalysz, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 6

[:Gijs (he/him)]

(In reply to Martijn from comment #0)

The option also isn't anywhere in the classic menu, not in the hamburger menu, nor does it have a keyboard shortcut. The context menu is literally the only way to get to the screenshotting function, and that option doesn't work in a frame.

It also exists in the page action menu (dots in the hamburger menu), and you can right click it to make it a permanently-visible item in the address bar, if this is a feature you use often.

There's also a shortcut - ctrl-shift-s.

Comment 7

[Chris Adams]

I just noticed this bug on https://console.aws.amazon.com — Firefox 88 removed the page action menu so I hadn't noticed it was missing from some context menus.

Comment 8

[Emma Malysz]

Meridel, is the "Take a screenshot" item something we should consider adding to the image-only context menu?
https://docs.google.com/presentation/d/1Ufd0A3HsziyXXAjXYNH84P2bu7RdTxARsA0xpKmwIWs/edit#slide=id.gb7754f26c5_10_34. I think that may make sense given images can take up a large portion of the screen (making the screenshots option unavailable in the context menu if they click the image) and that images are often what people hope to capture in their screenshots

If not, I think we should close this as WONTFIX.

Comment 9

[Meridel [:meridel]]

The Image Context menu already contains "Save Image As..." Doesn't this achieve the same end goal as "Take Screenshot", or is it that people want the ability to crop and screenshot a selection of the image? Thoughts?

Comment 10

[:Gijs (he/him)]

(In reply to Meridel [:meridel] from comment #9)

The Image Context menu already contains "Save Image As..." Doesn't this achieve the same end goal as "Take Screenshot", or is it that people want the ability to crop and screenshot a selection of the image? Thoughts?

I'm unsure, passing back to Emma.

Also, Emma, can you clarify why you asked about images? Are the frames this bug mentions normally filled with images?

Comment 11

[Emma Malysz]

Ah, I had just clicked directly on the image that was nested within the frame. With both images and frames, there are indeed options to "Save ____ as".

Saving is not directly the same as taking a screenshot, as we provide additional functionality to copy, save the entire page, or save the visible portion of the page. However, since images also provide us with the copy ability, I think it's fair to leave it out of there.

(In reply to Martijn from comment #4)

In case you're unfamiliar with Storybook, the Canvas pane is one giant iframe, and you will not get the screenshot option in the context menu there.
But in general the menu item is missing on any iframe, not just that one.

I think the reporter makes a valid point for clicking within iframes though. The "Save frame as" is a nested context menu option, and there is no ability to copy the frame. Images and different elements can be contained within the frame that the user is hoping to select some/all of for screenshots.

The context menu for that case currently has:

Select All
______
This Frame
_____

What do we think about making this:

Select All
____
Take a screenshot
_____
This frame
_____

Comment 12

[Meridel [:meridel]]

Emma, can you share a screenshot of the entire context menu for the iframe context?

Comment 13

[Emma Malysz]

Attachment: Screen Shot 2021-04-29 at 11.52.13 AM.png

Comment 14

[Emma Malysz]

I attached a screenshot to the bug with the iframe context.

The fix for this would be pretty simple and involve removing this line: https://searchfox.org/mozilla-central/rev/71515d047cbdd02687a1b9b7265f2ffb51300bf1/browser/base/content/nsContextMenu.js#1143.
That would get us to the structure I mentioned from comment #11

Comment 15

[Haik Aftandilian [:haik]]

I think this bug should be a higher priority. Now that the screenshot option has been removed from the page info menu, and it's not always clear when content is in an iframe, it may be confusing when the screenshot option is not present.

Comment 16

[Meridel [:meridel]]

Since the image only context menu already includes options for saving and copying an image, and to avoid adding an additional item to all image context menus, could we populate the "Take Screenshot" option within the "This Frame" submenu?

Comment 17

[Emma Malysz]

Confirmed with Meridel that we should place the option in the subframe. The subframe should look something like:

Print Frame...
-------
Take a Screenshot
-------
View Frame Source

Comment 18

[Kajal Sah]

Attachment: Bug 1679313 - Adds screenshot option in frames.r?emalysz

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f2b14c2021c
Adds screenshot option in frames.r=emalysz,fluent-reviewers,sfoster,flod

Comment 21

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5f2b14c2021c