1679431 - mozphab no longer works through HTTP proxy

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[David Ward]

The change in bug 1597264 no longer allows mozphab to connect through an HTTP proxy.

Prior to this change, HTTPS requests were performed with urllib.request.urlopen. This method automatically uses an HTTP proxy based on the *_proxy environment variables.

Now, the http.client.HTTPSConnection class is used directly (or if allowed, http.client.HTTPConnection). The Python documentation points out that it is not normal to do this, but rather to use urllib.request.urlopen instead.

Comment 1

[:glob ✱]

Attachment: Bug 1679431 - use urllib's urlopen to regain http proxy support; r=zeid

Comment 2

[:glob ✱]

https://github.com/mozilla-conduit/review/commit/30f48b947251f64e8e29ede6cb4b21a229f6a3a7

Comment 3

[David Ward]

Thank you for this change! However, this fix is incomplete: the connection to the Bugzilla server requires a similar change (in mozphab/bmo.py).

Comment 4

[:glob ✱]

As this has already landed I'll file a new bug to track the other issue.