Closed Bug 1679521 Opened 5 years ago Closed 5 years ago

[Fission] Sorting cards on Trello via "Card Priority by Screenful" power-up doesn't work when Fission is enabled

Categories

(Core :: DOM: Navigation, defect, P2)

Firefox 85
defect

Tracking

()

RESOLVED FIXED
Fission Milestone M6c
Tracking Status
firefox85 --- fixed

People

(Reporter: mystiquewolf, Assigned: emilio)

References

Details

(Keywords: nightly-community)

Attachments

(4 files)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

  1. Enable Fission
  2. Create a Trello board and add some cards to it.
  3. Install/Enable the power-up (https://screenful.com/card-priority-for-trello/) for the Trello board
  4. Add some priorities to the cards you've added
  5. Reload the page of Trello board
  6. Try to sort the cards via Priority.

Actual results:

Options for sorting the cards via priority are not shown in the dropdown. There are IframeIO errors in the console.

Expected results:

Like it happens when Fission is disabled, there should be only cookie warnings in yellow in the console and the "Show cards by priority" options should load.

Attached file Troubleshooting info
Attached image How to sort the cards
Attached image Sort by priority loaded

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → DOM: Navigation
Product: Firefox → Core

Nika can reproduce this bug. Intermittent timeout of iframe postMessage() after 500 ms? Turn on logging of postMessage() to debug.

Tracking for Fission M6c because Trello is a popular site.

Status: UNCONFIRMED → NEW
Fission Milestone: --- → M6c
Ever confirmed: true
Assignee: nobody → nika
Severity: -- → S3
Status: NEW → ASSIGNED
Priority: -- → P2

Taking since per Nika's comments the issue is that we're throttling the oop iframe, and we should only throttle rAF as we do for in-process frames

This basically answers one of the pending questions on bug 1635914 about how we should treat the .isActive flag on OOP iframes. So yay, two bugs one shot or something.

Assignee: nika → emilio
Flags: needinfo?(emilio)

This should be fixed now, but I don't have a Trello thing around. Nika, mind confirming?

Flags: needinfo?(emilio) → needinfo?(nika)

I'm with build 20201211213049 and there are no newer updates yet here. As far as i can see, this is still an issue.
If i leave the trello board open for a minute or maybe two, then the sorting options show up. But they don't show up immediately like in Chrome. This was that way when i filed the bug, and is also that way now.

Let's see if Nika can reproduce.

First build with the patch is 20201212092303 (the patch was merged three hours ago).

Depends on: 1635914

It's fixed here, let's see what Nika is going to say, yay!

I was able to repro and confirm that this is fixed now. Thanks Emilio!

Flags: needinfo?(nika)
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: