1679735 - Require recent user gesture for getDisplayMedia()

Status: RESOLVED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Karl Tomlinson (:karlt)]

"triggered by user activation" seems to have been the intention of "called from a user gesture handler".

The spec has since loosened this to "transient activation".

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: Bug 1679735 test getDisplayMedia() after user activation is consumed r?jib

Comment 2

[Karl Tomlinson (:karlt)]

Attachment: Bug 1679735 require recent user gesture for getDisplayMedia() r?jib

Previous behavior was to allow requests if the user has ever interacted with
the window. This patch changes from sticky activation to transient
activation.

WindowContext is used rather than Document for the
HasValidTransientUserGestureActivation() test because user activation is a
property of the Window/global.

The error reported when WindowContext is null is the same as that for missing
transient activation, which is keeping the existing behavior.
https://searchfox.org/mozilla-central/rev/66547980e8e8ca583473c74f207cae5bac1ed541/dom/base/Document.cpp#15806
i.e. a missing WindowContext is still treated as missing transient activation.

Depends on D98274

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5e17b1112257
test getDisplayMedia() after user activation is consumed r=jib
https://hg.mozilla.org/integration/autoland/rev/1fcd9c941737
require recent user gesture for getDisplayMedia() r=jib

Comment 4

[Natalia Csoregi [:nataliaCs]]

Backed out for failures on getdisplaymedia-user-activation-consumed.https.html

backout: https://hg.mozilla.org/integration/autoland/rev/b1b96cd1f5513abfce62062e8f905dd4491c896c

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=1fcd9c94173733aa56a49f0dbeff890bd9557b62

failure log: https://treeherder.mozilla.org/logviewer?job_id=324017237&repo=autoland&lineNumber=3609

[task 2020-12-09T07:27:15.566Z] 07:27:15 INFO - TEST-FAIL | /svg/struct/UnknownElement/interface.svg | Interface of unknown element - SVGUnknownElement is not defined
[task 2020-12-09T07:27:15.566Z] 07:27:15 INFO - @http://web-platform.test:8000/svg/struct/UnknownElement/interface.svg:16:5
[task 2020-12-09T07:27:15.566Z] 07:27:15 INFO - Test.prototype.step@http://web-platform.test:8000/resources/testharness.js:2044:25
[task 2020-12-09T07:27:15.566Z] 07:27:15 INFO - test@http://web-platform.test:8000/resources/testharness.js:572:30
[task 2020-12-09T07:27:15.566Z] 07:27:15 INFO - @http://web-platform.test:8000/svg/struct/UnknownElement/interface.svg:14:5
[task 2020-12-09T07:27:15.566Z] 07:27:15 INFO - TEST-UNEXPECTED-FAIL | /_mozilla/screen-capture/getdisplaymedia-user-activation-consumed.https.html | Test getDisplayMedia() after user activation is consumed - promise_test: Unhandled rejection with value: object "TypeError: navigator.mediaDevices.getDisplayMedia is not a function"
[task 2020-12-09T07:27:15.675Z] 07:27:15 INFO - TEST-OK | /_mozilla/screen-capture/getdisplaymedia-user-activation-consumed.https.html | took 729ms

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/227f7ace8545
test getDisplayMedia() after user activation is consumed r=jib
https://hg.mozilla.org/integration/autoland/rev/3faff9d75a5d
require recent user gesture for getDisplayMedia() r=jib

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/227f7ace8545
https://hg.mozilla.org/mozilla-central/rev/3faff9d75a5d

Comment 7

[Marco Castelluccio [:marco]]

Set release status flags based on info from the regressing bug 1704278

Comment 8

[Marco Castelluccio [:marco]]

Sorry for the noise, I was debugging the bot and wrongly run it.