1679768 - Part 1 of the fix for bug 1675939 was unnecessary and causes a display regression

Status: RESOLVED FIXED

(MailNews Core :: Security: OpenPGP, defect)

Description

[Kai Engert [:KaiE:]]

In bug 1675939 we landed two parts.

Part 1 plus bustage fix:
https://hg.mozilla.org/comm-central/rev/bfa8183cf7b8
https://hg.mozilla.org/comm-central/rev/4ace0f66e67d

Part 2:
https://hg.mozilla.org/comm-central/rev/3396fcaf2cdc

I believe only part 2 was necessary to fix bug 1675939.

Part 1 was an initial attempt, which we learned had no effect towards fixing bug 1675939.

And Part 1 has introduced a regression.
If we process an OpenPGP signed message, and the signature verification fails, then our user interface will (incorrectly report that the message is encrypted, and (incorrectly) report that the message cannot be decrypted.

I suggest to backout part 1.

It would be good to get test confirmation that bug 1675939 is still fixed after the backout.

Comment 1

[Kai Engert [:KaiE:]]

Attachment: Bug 1679768 - Backout unnecessary change from bug 1675939 that introduced a regression. r=PatrickBrunschwig

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4724c2df0ecf
Backout unnecessary change from bug 1675939 that introduced a regression. r=PatrickBrunschwig DONTBUILD

Comment 3

[Kai Engert [:KaiE:]]

Comment on attachment 9190288 [details]
Bug 1679768 - Backout unnecessary change from bug 1675939 that introduced a regression. r=PatrickBrunschwig

[Approval Request Comment]
Regression caused by (bug #): 1675939
User impact if declined: false status display
Testing completed (on c-c, etc.):
Risk to taking this patch (and alternatives if risky): low

Comment 4

[Kai Engert [:KaiE:]]

Comment on attachment 9190288 [details]
Bug 1679768 - Backout unnecessary change from bug 1675939 that introduced a regression. r=PatrickBrunschwig

got a=wsmwk in chat

Comment 5

[Kai Engert [:KaiE:]]

that is, approved for 78.5.1 and I assume beta, too

Comment 6

[Rob Lemley [:rjl]]

Thunderbird 78.5.1:
https://hg.mozilla.org/releases/comm-esr78/rev/47446a6e6178

Comment 7

[Dave Miller [:justdave]]

Thunderbird 84.0b3
https://hg.mozilla.org/releases/comm-beta/rev/821bffa8e48a