1679819 - Ensure "contain:size" makes absolute positioned elements monolithic

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Bug 1470329 made contain:size element monolithic by setting the element's available block-size to NS_UNCONSTRAINEDSIZE in Reflowinput::Init().

However, for an absolute positioned element, the absolute containing block overrides its available block-size after the ReflowInput is constructed. We need to consider IsContainSize when calculating the abs-pos child's available block-size, or pass the correct available block-size to ReflowInput's constructor.

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1679819 Part 1 - Move the computation of border and margin closer to its usage in ReflowAbsoluteFrame().

This patch shouldn't change the behavior.

Comment 2

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1679819 Part 2 - Compute abs-pos elements' available block-size, and pass it to ReflowInput's constructor.

This ensures abs-pos frame with size containment is monolithic because
ReflowInput::Init() can override available block-size to an
unconstrained size if the frame has size containment (Bug 1470329).

Depends on D98226

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5a1afa9b7c44
Part 1 - Move the computation of border and margin closer to its usage in ReflowAbsoluteFrame(). r=emilio
https://hg.mozilla.org/integration/autoland/rev/954ba4c01157
Part 2 - Compute abs-pos elements' available block-size, and pass it to ReflowInput's constructor. r=layout-reviewers,emilio

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/26688 for changes under testing/web-platform/tests

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/5a1afa9b7c44
https://hg.mozilla.org/mozilla-central/rev/954ba4c01157

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot