Closed Bug 1679861 Opened 4 years ago Closed 4 years ago

un-blocklisted addon is not re-added in search service

Categories

(Firefox :: Search, defect, P2)

Product:
Firefox
Component:
Search
Type:
defect

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1646338

People

(Reporter: mixedpuppy, Unassigned)

Details

If an addon is blockisted, then un-blocklisted (e.g. via update), the engine is not added back into the search service.

It will get added back upon restart, so I suspect this is a low severity. However, it may also be an issue for an addon that adds a search engine during an update (v1 doesn't have an engine, v2 does), which I'd give a higher severity for.

The reason is that it is seen by the search service as an upgrade and it attempts to upgrade an engine that it does not have.

https://searchfox.org/mozilla-central/rev/168c45a7acc44e9904cfd4eebcb9eb080e05699c/toolkit/components/search/SearchService.jsm#1638-1643

STR

  1. disable blocklist
  2. install an addon that would be blocked
  3. enable blocklist
  4. verify addon is blocked, engine is removed
  5. install/update to a version that is not blocklisted

EXPECTED:
engine is listed in search (about:preferences)

ACTUAL:
engine is not listed in search

Severity: -- → S4
Priority: -- → P2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.