1679883 - Hide separators in mail window better

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Message Display, task)

Description

[Ian Neal]

Following on from Bug 1600103, the hiding of separators in the folder pane and message pane context menus needs to be done better.

Comment 1

[Ian Neal]

Attachment: better hiding

From what I can see on Linux, using a better hideIfAppropriate function means that checkLastSeparator is no longer needed or the checking for onLink. Hopefully that is the same on Windows and macOS. Requesting feedback.

Comment 2

[Ian Neal]

Attachment: better hiding v1.1

Fixed comment and removed extra LF as mentioned on IRC.

[Approval Request Comment]
Regression caused by (bug #): 1600103
User impact if declined: extra separators
Testing completed (on m-c, etc.): 2.53.6
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none

Comment 3

[Frank-Rainer Grahl (:frg)]

Comment on attachment 9191509 [details] [diff] [review]
better hiding v1.1

LGTM

• hideIfAppropriate("folderPaneContext-sep-edit");
• hideIfAppropriate("folderPaneContext-sep1");
• hideIfAppropriate("folderPaneContext-sep4");

folderPaneContext-sep-edit comes after -sep1. Doesn't make a practial difference with the algorithm but shouldn't -sep1 be checked first?

r/a+ either way.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/ad79488515ed
Hide separators in mail window better. r=frg

Comment 5

[Frank-Rainer Grahl (:frg)]

https://gitlab.com/seamonkey-project/seamonkey-2.53-comm/-/commit/dd094bbbebc7b601e000d95d63c1e14042ce91b6
Hide separators in mail window better. r=frg a=frg