Following on from Bug 1600103, the hiding of separators in the folder pane and message pane context menus needs to be done better.
From what I can see on Linux, using a better hideIfAppropriate function means that checkLastSeparator is no longer needed or the checking for onLink. Hopefully that is the same on Windows and macOS. Requesting feedback.
Fixed comment and removed extra LF as mentioned on IRC.
[Approval Request Comment]
Regression caused by (bug #): 1600103
User impact if declined: extra separators
Testing completed (on m-c, etc.): 2.53.6
Risk to taking this patch (and alternatives if risky): none
String changes made by this patch: none
Comment on attachment 9191509 [details] [diff] [review]
better hiding v1.1
folderPaneContext-sep-edit comes after -sep1. Doesn't make a practial difference with the algorithm but shouldn't -sep1 be checked first?
r/a+ either way.
Pushed by firstname.lastname@example.org:
Hide separators in mail window better. r=frg
Hide separators in mail window better. r=frg a=frg