1679890 - Change UrlbarProviderExtension.notificationTimeout into a pref

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P2)

Description

[Harry Twyford]

[Tracking Requested - why for this release]:
We'd like to ship this change in 84 to meet the timeline for a planned experiment. The change will be narrowly scoped to only affect Urlbar extensions, which can currently only be used by Mozilla in experiments. No other Urlbar experiments are running in 84.

---

UrlbarProviderExtension.notificationTimeout controls how long extensions have to return a result before they timeout. The default value is 200ms. This may not be enough time to get a response from some web services that we want to experiment with in the Urlbar. We should change notificationTimeout into a hidden pref that Urlbar experimental add-ons can set via experimental APIs.

Comment 1

[Harry Twyford]

https://treeherder.mozilla.org/jobs?repo=try&revision=7abe188765b6d1b8a9e583e230489001dd2d75de

Comment 2

[Harry Twyford]

Attachment: Bug 1679890 - Change UrlbarProviderExtension.notificationTimeout into a pref. r?adw!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fe6d35236c45
Change UrlbarProviderExtension.notificationTimeout into a pref. r=adw

Comment 4

[Harry Twyford]

Attachment: Bug 1679890 - Change the default value of browser.urlbar.extension.timeout to 400ms. r?adw!

Per bug 1680037 comment 1.

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/fe6d35236c45

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b4c317421a5
Change the default value of browser.urlbar.extension.timeout to 400ms. r=adw

Comment 7

[Harry Twyford]

Comment on attachment 9190417 [details]
Bug 1679890 - Change UrlbarProviderExtension.notificationTimeout into a pref. r?adw!

Beta/Release Uplift Approval Request

• User impact if declined: Mozilla won't be able to run an experiment it has planned for 84 (bug 1678126).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch is narrowly scoped to only affect Urlbar extensions, which can currently only be used by Mozilla in experiments. No other Urlbar experiments are running in 84. It's a three-line change plus some changes to tests.
• String changes made/needed:

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/7b4c317421a5

Comment 9

[Harry Twyford]

(In reply to Harry Twyford [:harry] from comment #7)

• Has the fix been verified in Nightly?: No Yes

I verified this in Nightly today.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9190417 [details]
Bug 1679890 - Change UrlbarProviderExtension.notificationTimeout into a pref. r?adw!

Approved for 84.0b8.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/5c2f70b5469f
https://hg.mozilla.org/releases/mozilla-beta/rev/185a9dadb0cd