1679985 - about:buildconfig should be clear that not all options are listed on the page

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P5)

Description

[Sylvestre Ledru [:Sylvestre]]

Currently, I see

-Qunused-arguments -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wempty-init-stmt -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wunused-function -Wunused-variable -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-error=tautological-type-limit-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wno-error=deprecated-copy -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-psabi -Wno-unknown-warning-option -D_GLIBCXX_USE_CXX11_ABI=0 -fno-sized-deallocation -fno-aligned-new -fcrash-diagnostics-dir=/builds/worker/artifacts -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -O3 -fno-omit-frame-pointer -funwind-tables

We should also see -fstack-protector-strong & -fstack-clash-protection

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Andi, is that something you could help with?
(note that -fstack-clash-protection is linux & android only flags)
merci!

Comment 2

[(Away)]

This is because -fstack-protector-strong etc. are not being put into the standard CFLAGS. They live in a special thing MOZ_HARDENING_CFLAGS.

IMO this bug is not worth investing resources into, just to get this one use case to show up. The flags in about:buildconfig are necessarily an oversimplified view of what the build is using. There are complexities that can't be captured by a one-liner, for example the MOZ_HARDENING flags are different depending on whether the current file is under js/ or not. Additionally there are a ton of other special flag groups: https://searchfox.org/mozilla-central/search?q=context.config.substs.get.*FLAGS&path=context.py&case=true&regexp=true

Comment 3

[Sylvestre Ledru [:Sylvestre]]

OK, what about updating this page to write something like
"please be aware that this page doesn't reflect all the options used to build Firefox"

Do you think we should add the stack options into about about:support instead?

Comment 4

[(Away)]

(In reply to Sylvestre Ledru [:Sylvestre] from comment #3)

OK, what about updating this page to write something like
"please be aware that this page doesn't reflect all the options used to build Firefox"

Sounds reasonable to me!

Do you think we should add the stack options into about about:support instead?

If we're expecting this to be a bumpy landing with several toggles coming up, that would be good. But if the intent is "after nightly 12345 we expect this to be on forever" then it doesn't really add new information for support purposes.

Comment 5

[Sylvestre Ledru [:Sylvestre]]

If we're expecting this to be a bumpy landing with several toggles coming up, that would be good. But if the intent is "after nightly 12345 we expect
this to be on forever" then it doesn't really add new information for support purposes.

Nah, I am expecting that we will never chat about this stuff again :)
(last famous words ;)

Comment 6

[(Away)]

Oh now you definitely have to add it :P

Comment 7

[Sylvestre Ledru [:Sylvestre]]

So, for the good first bug, the goal is to update
https://searchfox.org/mozilla-central/source/toolkit/content/buildconfig.html
to add the sentence from comment #3:
"please be aware that this page doesn't reflect all the options used to build Firefox"

Probably before Source

Comment 8

[Dhanesh]

hii.. @sylvestre , I am newbie to this Firefox developer community.So can i take this issue to work on?

Ive read the thing.That i gonna write the sentence as slyvestre said .But the thing is should i write the content enclosed in a html element or should i write it as a comment?

Early apologies if u think this is childish since I am newbie to this.

Thanks .

Comment 9

[Mitchell Hentges [:mhentges] 🦀]

Hey Dhanesh! 👋
I'm glad you're interested in this ticket :)
You should write the content in an HTML element so that it's visible to people looking at the about:buildconfig page.

Feel free to ask other questions here or in the #build channel in Matrix if you'd like 👍

Comment 10

[Dhanesh]

Attachment: Bug 1679985 Added the aware lines in about:buildconfig page

Comment 11

[Dhanesh]

Attachment: Bug 1679985 Added the aware lines in about:buildconfig page

Depends on D111410

Comment 12

[Dhanesh]

Attachment: Bug 1679985 Added the aware lines in about:buildconfig page

Depends on D111410

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8579542608e
Added the aware lines in about:buildconfig page r=mhentges

Comment 14

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/c8579542608e