consider lowering frequency of l10n-bumper cron task
Categories
(Firefox Build System :: Task Configuration, task)
Tracking
(firefox84 fixed, firefox85 fixed)
People
(Reporter: jcristau, Assigned: jcristau)
Details
Attachments
(1 file)
l10n-bumper runs at 45 past every hour on mozilla-beta. In earlier days, most of the time it was a no-op, because it relied on manual signoffs for updates, which didn't happen that often. Nowadays, it can lead to pushlogs like https://hg.mozilla.org/releases/mozilla-beta/pushloghtml?fromchange=41c63a183099&tochange=ec23815a5ad0a81eb9532cbb4efa2d4eedf2589c which seem noisy and kind of pointless, making it harder to trawl through hg logs or things like going back to a non-DONTBUILD push in treeherder.
Could we consider reducing the frequency of these updates to every, say, 6 or 12 hours, to batch more updates in a single push? With beta builds every 2 to 3 days that should still get updates to users in a timely fashion. Flod, what do you think?
|
||
Comment 1•3 years ago
|
||
(In reply to Julien Cristau [:jcristau] from comment #0)
Could we consider reducing the frequency of these updates to every, say, 6 or 12 hours, to batch more updates in a single push? With beta builds every 2 to 3 days that should still get updates to users in a timely fashion. Flod, what do you think?
I'm definitely OK with running it less frequently.
l10n-changesets.json is only used for Beta builds. If there is a way to ensure that we update it before starting a new beta build, then running it even every 24h would be enough.
|
Assignee | |
Comment 2•3 years ago
|
||
(In reply to Francesco Lodolo [:flod] from comment #1)
(In reply to Julien Cristau [:jcristau] from comment #0)
Could we consider reducing the frequency of these updates to every, say, 6 or 12 hours, to batch more updates in a single push? With beta builds every 2 to 3 days that should still get updates to users in a timely fashion. Flod, what do you think?
I'm definitely OK with running it less frequently.
Cool, thanks.
It also runs hourly on central, AIUI to catch locales added/removed from all-locales. I guess that's also fine to run daily?
l10n-changesets.json is only used for Beta builds. If there is a way to ensure that we update it before starting a new beta build, then running it even every 24h would be enough.
Sounds doable, if we run it daily at 1900Z or so, and remove the DONTBUILD for those runs, it'll be picked up by the automated 2100Z beta builds.
|
|
Assignee | |
Comment 3•3 years ago
|
||
To ensure l10n updates are still picked up by beta builds in a timely
fashion, remove "DONTBUILD" from commit messages when running on
mozilla-beta, and run a couple of hours before the "daily-releases" job
starts.
|
|
||
Comment 4•3 years ago
|
||
(In reply to Julien Cristau [:jcristau] from comment #2)
(In reply to Francesco Lodolo [:flod] from comment #1)
(In reply to Julien Cristau [:jcristau] from comment #0)
Could we consider reducing the frequency of these updates to every, say, 6 or 12 hours, to batch more updates in a single push? With beta builds every 2 to 3 days that should still get updates to users in a timely fashion. Flod, what do you think?
I'm definitely OK with running it less frequently.
Cool, thanks.
It also runs hourly on central, AIUI to catch locales added/removed from all-locales. I guess that's also fine to run daily?
Yes, daily is more than enough for that. I assume most runs would be a no-op, since we add locales maybe once or twice a year.
l10n-changesets.json is only used for Beta builds. If there is a way to ensure that we update it before starting a new beta build, then running it even every 24h would be enough.
Sounds doable, if we run it daily at 1900Z or so, and remove the DONTBUILD for those runs, it'll be picked up by the automated 2100Z beta builds.
Sounds good.
|
||
Updated•3 years ago
|
Pushed by rvandermeulen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9bd89da852cf run l10n-bumper daily instead of hourly. r=releng-reviewers,jmaher
|
||
Comment 6•3 years ago
|
||
Backed out for causing gecko decision tasks to fail
backout: https://hg.mozilla.org/integration/autoland/rev/71ca5351d995d6a8a91a2a7c04191d13557da546
failure log: https://treeherder.mozilla.org/logviewer?job_id=323210007&repo=autoland&lineNumber=561
[task 2020-12-01T19:25:15.499Z] Error loading tasks for kind l10n-bump:
[task 2020-12-01T19:25:15.500Z] Traceback (most recent call last):
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/util/schema.py", line 27, in validate_schema
[task 2020-12-01T19:25:15.500Z] schema(obj)
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/third_party/python/voluptuous/voluptuous/schema_builder.py", line 267, in call
[task 2020-12-01T19:25:15.500Z] return self._compiled([], data)
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/third_party/python/voluptuous/voluptuous/schema_builder.py", line 589, in validate_dict
[task 2020-12-01T19:25:15.500Z] return base_validate(path, iteritems(data), out)
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/third_party/python/voluptuous/voluptuous/schema_builder.py", line 427, in validate_mapping
[task 2020-12-01T19:25:15.500Z] raise er.MultipleInvalid(errors)
[task 2020-12-01T19:25:15.500Z] voluptuous.error.MultipleInvalid: expected bool for dictionary value @ data['dontbuild']
[task 2020-12-01T19:25:15.500Z]
[task 2020-12-01T19:25:15.500Z] During handling of the above exception, another exception occurred:
[task 2020-12-01T19:25:15.500Z]
[task 2020-12-01T19:25:15.500Z] Traceback (most recent call last):
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/mach_commands.py", line 324, in taskgraph_decision
[task 2020-12-01T19:25:15.500Z] ret = taskgraph.decision.taskgraph_decision(options)
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/decision.py", line 234, in taskgraph_decision
[task 2020-12-01T19:25:15.500Z] full_task_json = tgg.full_task_graph.to_json()
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 174, in full_task_graph
[task 2020-12-01T19:25:15.500Z] return self._run_until("full_task_graph")
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 417, in _run_until
[task 2020-12-01T19:25:15.500Z] k, v = next(self._run)
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 294, in _run
[task 2020-12-01T19:25:15.500Z] self._write_artifacts,
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 92, in load_tasks
[task 2020-12-01T19:25:15.500Z] for task_dict in transforms(trans_config, inputs)
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 80, in <listcomp>
[task 2020-12-01T19:25:15.500Z] Task(
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/task.py", line 2110, in check_run_task_caches
[task 2020-12-01T19:25:15.500Z] for task in tasks:
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/task.py", line 2018, in check_task_dependencies
[task 2020-12-01T19:25:15.500Z] for task in tasks:
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/task.py", line 2004, in check_task_identifiers
[task 2020-12-01T19:25:15.500Z] for task in tasks:
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/task.py", line 1985, in chain_of_trust
[task 2020-12-01T19:25:15.500Z] for task in tasks:
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/task.py", line 1776, in build_task
[task 2020-12-01T19:25:15.500Z] for task in tasks:
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/task.py", line 1767, in try_task_config_routes
[task 2020-12-01T19:25:15.500Z] for task in tasks:
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/task.py", line 1757, in try_task_config_chemspill_prio
[task 2020-12-01T19:25:15.500Z] for task in tasks:
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/task.py", line 1747, in try_task_config_env
[task 2020-12-01T19:25:15.500Z] for task in tasks:
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/task.py", line 1709, in add_index_routes
[task 2020-12-01T19:25:15.500Z] for task in tasks:
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/transforms/task.py", line 1513, in validate
[task 2020-12-01T19:25:15.500Z] "In task.run {!r}:".format(task.get("label", "?no-label?")),
[task 2020-12-01T19:25:15.500Z] File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/util/schema.py", line 32, in validate_schema
[task 2020-12-01T19:25:15.500Z] raise Exception("\n".join(msg) + "\n" + pprint.pformat(obj))
[task 2020-12-01T19:25:15.500Z] Exception: In task.run 'l10n-bump-l10n-bumper':
[task 2020-12-01T19:25:15.500Z] expected bool for dictionary value @ data['dontbuild']
Pushed by jcristau@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e2aaec05c9c9 run l10n-bumper daily instead of hourly. r=releng-reviewers,jmaher,aki
|
|
Assignee | |
Updated•3 years ago
|
|
||
Comment 8•3 years ago
|
||
| bugherder uplift | ||
|
||
Comment 9•3 years ago
|
||
| bugherder | ||
Description
•