1680031 - Abort operations for given directory lock ids

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

Currently, when an origin is being cleared we go through the directory locks which block the clear operation and collect clients which need to be notified with AbortOperations(aOrigin).
However, this aborts all operations for given origin. The clear operation can now only clear data for given persistence type or client type. So we need to abort operations for given directory locks (instead for given origin), otherwise we can end up aborting operations for storages which are not about to be cleared.
I want to convert OpenDirectory to use MozPromise instead of a custom listener and this bug needs to be done first
Finally, I plan to use MozPromise for the asynchronous initialization methods, so if OpenDirectory uses that too, we can probably chain all that in a nice way.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1680031 - QM: Give ids to all directory locks; r=#dom-workers-and-storage-reviewers

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1680031 - Introduce Client::AbortAllOperations; r=#dom-workers-and-storage-reviewers

Client::AbortOperations no longer supports the case when an empty origin string
is passed (which was used to abort all operations).

Depends on D98343

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1680031 - LSNG: Change InvalidatePrepareDatastoreOpsMatching and InvalidatePreparedDatastoresMatching to free functions; r=#dom-workers-and-storage-reviewers

These methods are only used in QuotaClient class, so they don't need to be global.

Depends on D98344

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1680031 - LSNG: Various cleanup related to abort operations methods; r=#dom-workers-and-storage-reviewers

Depends on D98345

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1680031 - IDB: Change InvalidateLiveDatabasesMatching to a free function; r=#dom-workers-and-storage-reviewers

This is just a minor cleanup.

Depends on D98346

Comment 6

[Jan Varga [:janv]]

Attachment: Bug 1680031 - IDB: Change argument type of Condition in InvalidateLiveDatabasesMatching to a reference; r=#dom-workers-and-storage-reviewers

A minor cleanup

Depends on D98347

Comment 7

[Jan Varga [:janv]]

Attachment: Bug 1680031 - DOMCACHE: Change argument type of Condition in AbortMatching to a reference; r=#dom-workers-and-storage-reviewers

Depends on D98348

Comment 8

[Jan Varga [:janv]]

Attachment: Bug 1680031 - SDB: Change argument type of Condition in AllowToCloseConnectionsMatching to a reference; r=#dom-workers-and-storage-reviewers

Depends on D98430

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3f0236595b7
QM: Give ids to all directory locks; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/57ec107c7fa0
Introduce Client::AbortAllOperations; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/78f865f179f6
IDB: Change argument type of Condition in InvalidateLiveDatabasesMatching to a reference; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/8beb762b9dae
DOMCACHE: Change argument type of Condition in AbortMatching to a reference; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/1e466374bc50
SDB: Change argument type of Condition in AllowToCloseConnectionsMatching to a reference; r=dom-workers-and-storage-reviewers,sg

Comment 10

[Jan Varga [:janv]]

Attachment: Bug 1680031 - SDB: Change AllowToCloseConnectionsMatching to a free function; r=#dom-workers-and-storage-reviewers

Depends on D98345

Comment 11

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/a3f0236595b7
https://hg.mozilla.org/mozilla-central/rev/57ec107c7fa0
https://hg.mozilla.org/mozilla-central/rev/78f865f179f6
https://hg.mozilla.org/mozilla-central/rev/8beb762b9dae
https://hg.mozilla.org/mozilla-central/rev/1e466374bc50

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bad84766f83c
LSNG: Various cleanup related to abort operations methods; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/10736db2685a
IDB: Change InvalidateLiveDatabasesMatching to a free function; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/de20363fdc0f
SDB: Change AllowToCloseConnectionsMatching to a free function; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/c7e3c04eb74e
LSNG: Change InvalidatePrepareDatastoreOpsMatching and InvalidatePreparedDatastoresMatching to free functions; r=dom-workers-and-storage-reviewers,sg

Comment 13

[Jan Varga [:janv]]

Attachment: Bug 1680031 - Abort operations for given directory lock ids; r=#dom-workers-and-storage-reviewers

This patch changes the way how we abort operations when clearing of data is
requested. Instead of aborting all operations for given origin, we now abort
all operations for given directory locks which are blocking clearing of data.

Depends on D98345

Comment 14

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/bad84766f83c
https://hg.mozilla.org/mozilla-central/rev/10736db2685a
https://hg.mozilla.org/mozilla-central/rev/de20363fdc0f
https://hg.mozilla.org/mozilla-central/rev/c7e3c04eb74e

Comment 15

[Simon Giesecke [:sg] [he/him]]

The core patch has not yet landed, so reopening.

I want to convert OpenDirectory to use MozPromise instead of a custom listener and this bug needs to be done first
Finally, I plan to use MozPromise for the asynchronous initialization methods, so if OpenDirectory uses that too, we can probably chain all that in a nice way.

This is not yet done. It's not clear to me if you want to do this within this bug, or in separate bugs? In the former case, we probably still need leave-open here.

Comment 16

[Jan Varga [:janv]]

Yes, I prematurely removed the leave-open flag, sorry.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0a8dbaa4c1bd
Abort operations for given directory lock ids; r=dom-workers-and-storage-reviewers,sg

Comment 18

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/0a8dbaa4c1bd