Closed Bug 1680057 Opened 5 years ago Closed 5 years ago

Windows build bustage with LTO and new pass manager enabled

Categories

(Firefox Build System :: Toolchains, defect)

defect

Tracking

(firefox-esr78 unaffected, firefox83 unaffected, firefox84 unaffected, firefox85 fixed)

RESOLVED FIXED
85 Branch
Tracking Status
firefox-esr78 --- unaffected
firefox83 --- unaffected
firefox84 --- unaffected
firefox85 --- fixed

People

(Reporter: RyanVM, Assigned: away)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

My local builds have LTO and the new pass manager enabled alongside the normal bootstrapped clang release. After bug 1679845, I'm hitting a fatal error during configure:

 0:06.24   File "C:/Users/Ryan/repos/mozilla/build/moz.configure/lto-pgo.configure", line 308, in lto
 0:06.25     elif select_linker.KIND != "ld64" and c_compiler.type == "clang":
 0:06.25 AttributeError: 'NoneType' object has no attribute 'KIND'

Windows being Windows, with its own spellings for everything, let's stay within the WINNT block regardless of whether we meet the compiler requirement.

Pushed by dmajor@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/726f26279667 New PM LTO: Don't take the elif block on Windows r=firefox-build-system-reviewers,mhentges
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: