Closed
Bug 1680060
Opened 3 years ago
Closed 3 years ago
Expose `glean::ErrorType` from FOG
Categories
(Toolkit :: Telemetry, enhancement, P1)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
86 Branch
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: Dexter, Assigned: chutten)
References
Details
(Whiteboard: [telemetry:fog:m?])
Attachments
(1 file)
From this review comment.
Does the fog crate need to re-expose ErrorType for our users' tests?
|
Assignee | |
Comment 1•3 years ago
|
||
Oh hey look, this is exposed already as fog::private::ErrorType. Encouraging people to use anything in the private module is a little suspect, though. Should we re-export it on fog itself? Jan-Erik, what do you think?
(Same thing applies to a few of the other pub use exports in here)
Status: NEW → RESOLVED
Closed: 3 years ago
Flags: needinfo?(jrediger)
Resolution: --- → FIXED
|
||
Comment 2•3 years ago
|
||
Yep, we should do that as it's part of the public API (e.g. test_get_num_recorded_errors)
Flags: needinfo?(jrediger)
|
|
Assignee | |
Comment 3•3 years ago
|
||
Easy enough.
Assignee: nobody → chutten
Severity: -- → N/A
Status: RESOLVED → REOPENED
Priority: -- → P1
Resolution: FIXED → ---
|
|
Assignee | |
Comment 4•3 years ago
|
||
Pushed by chutten@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4b7252680e90 Re-export some helpful types so FOG users can write tests r=janerik
|
||
Comment 6•3 years ago
|
||
| bugherder | ||
Status: REOPENED → RESOLVED
Closed: 3 years ago → 3 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•