Closed Bug 1680080 Opened 5 years ago Closed 5 years ago

Consider optimizing proc macros / build scripts.

Categories

(Firefox Build System :: General, enhancement)

enhancement

Tracking

(firefox85 fixed)

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(1 file)

See commit message incoming.

On a very parallel debug build, I see a long time just waiting for
bindgen / style compilation / geckoservo.

Turns out that a bunch of this is just proc macros / build scripts.

Optimizing it saves between 10 and 17 seconds of my debug build. We
might want to consider running bindgen much like cbindgen rather than
rebuilding it all the time, which should help a lot more, but my guess
is that this should still help with the pretty hot custom derives that
the style crate runs.

Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0c24a54b815a Optimize proc macros / build dependencies. r=glandium,firefox-build-system-reviewers,mhentges
Regressions: 1680654
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: