1680149 - Make a read-only CardDAV address book possible

Status: RESOLVED FIXED

(MailNews Core :: Address Book, enhancement)

Description

[Geoff Lankow (:darktrojan)]

It should be possible to have a CardDAV directory that syncs with the server but doesn't allow the user to make changes. If the readOnly property returns true then the UI responds appropriately, but it should be enforced by the back end. And there's currently no way to make the readOnly property return true.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1680149 - Make a read-only CardDAV address book possible. r?mkmelin

Read-only-ness is implemented in AddrBookDirectory, even though its a bit pointless to have a
read-only local directory. In the future, parts of this class will be split out into a base
class for other directory types, which may also need a read-only option.

Depends on D98400

Comment 2

[Geoff Lankow (:darktrojan)]

Um, oops.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/923f6d056a47
Make a read-only CardDAV address book possible. r=mkmelin

Comment 4

[Geoff Lankow (:darktrojan)]

Comment on attachment 9190709 [details]
Bug 1680149 - Make a read-only CardDAV address book possible. r?mkmelin

[Approval Request Comment]
User impact if declined: this is a nice-to-have, but quite a useful one for carddav
Testing completed (on c-c, etc.): in beta 85
Risk to taking this patch (and alternatives if risky): it does affect all address books but the user would have to go out of their way for it to cause a problem

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9190709 [details]
Bug 1680149 - Make a read-only CardDAV address book possible. r?mkmelin

[Triage Comment]
Approved for esr78

Comment 6

[Dave Miller [:justdave]]

This patch does not apply cleanly on esr78 and the scope of the merge is beyond my comfort level. Can you re-spin for esr78? Thanks!

Comment 7

[Geoff Lankow (:darktrojan)]

See https://treeherder.mozilla.org/jobs?repo=try-comm-central&revision=e39c84abd9c0421bc2fa5c9ad6da315fd2195cab for landing order.

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 78.7.1:
https://hg.mozilla.org/releases/comm-esr78/rev/ab6fc3070b8d