1680171 - error: attribute should be applied to a function or static

Status: RESOLVED FIXED

(Firefox :: Installer, defect)

Description

[Mike Hommey [:glandium]]

Building with rust 1.48 with warnings as errors (i.e. automation) fails with:

error: attribute should be applied to a function or static
   --> toolkit/mozapps/defaultagent/rust/src/lib.rs:111:5
    | 
111 |     #[no_mangle]
    |     ^^^^^^^^^^^^
112 |     static gWinEventLogSourceName: *const u16; 
    |     ------------------------------------------ not a function or static
    | 
    = note: `-D unused-attributes` implied by `-D warnings`
    = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
error: aborting due to previous error

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1680171 - Remove unnecessary no_mangle attribute.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52c68bee8952
Remove unnecessary no_mangle attribute. r=nalexander

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/52c68bee8952