1680175 - replace most uses of gtk_settings_get_for_screen() with gtk_settings_get_default()

Status: RESOLVED FIXED

(Core :: Widget: Gtk, task)

Description

[Cameron McCormack (:heycam)]

gtk_settings_get_default() is equivalent to gtk_settings_get_for_screen(gdk_screen_get_default()).

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Bug 1680175 - Replace most uses of gtk_settings_get_for_screen() with gtk_settings_get_default().

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8df4fc00437
Replace most uses of gtk_settings_get_for_screen() with gtk_settings_get_default(). r=karlt

Comment 3

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/c8df4fc00437

Comment 4

[Alexandru Ionescu (needinfo me) [:alexandrui]]

There are 4 bugs in the revision that caused the improvements below, this and Bug 1672097, Bug 1470983, and Bug 1672098. Which of those makes sense cause this improvement?
== Change summary for alert #28167 (as of Mon, 21 Dec 2020 04:48:51 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
14%	cpstartup	content-process-startup	linux64-shippable-qr	e10s stylo webrender-sw	123.58 -> 106.75
14%	cpstartup	content-process-startup	linux64-shippable	e10s stylo	118.83 -> 102.75
13%	cpstartup	content-process-startup	linux64-shippable-qr	e10s stylo webrender-sw	123.17 -> 106.75
12%	cpstartup	content-process-startup	linux64-shippable-qr	e10s stylo webrender	127.17 -> 111.33

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28167

Comment 5

[Andra Esanu (needinfo me)]

Hi! There are the same 4 bugs in this revision as well, this one, Bug 1672097, Bug 1470983 and Bug 1680175. Which one do you think can be the cause for the following improvements?

== Change summary for alert #28140 (as of Fri, 18 Dec 2020 13:13:22 GMT) ==

Improvements:

Ratio	Suite	Test	Platform	Options	Absolute values (old vs new)
9%	Base Content Heap Unclassified		linux1804-64-shippable		4,000,401.33 -> 3,642,838.67
9%	Base Content Heap Unclassified		linux1804-64-shippable		3,999,560.67 -> 3,643,159.33
9%	Base Content Heap Unclassified		linux1804-64-shippable-qr		4,043,684.67 -> 3,686,881.33
7%	Heap Unclassified		windows10-64-shippable-qr		50,150,975.21 -> 46,582,240.09
4%	Base Content Explicit		linux1804-64-shippable		10,137,258.67 -> 9,714,005.33
4%	Base Content Explicit		linux1804-64-shippable-qr		10,149,376.00 -> 9,738,581.33
3%	Heap Unclassified		linux1804-64-shippable		64,258,194.35 -> 62,490,454.35

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=28140

Comment 6

[Cameron McCormack (:heycam)]

Nice! These can all be attributed to bug 1470983.