1680216 - Measure time to render the contents of the bookmarks toolbar to assess whether we need placeholders (like skeleton UI)

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[:Gijs (he/him)]

We now delay when we render the bookmarks toolbar contents until shortly after startup. On fast machines, the difference is pretty small - the bookmarks appear practically instantaneously after the window shows. But on slower machines the difference may be more marked. We should measure it to see if we need placeholder content of sorts.

Comment 1

[:Gijs (he/him)]

Attachment: Bug 1680216 - measure paint delay induced by initializing bookmarks toolbar later, r?mconley

Comment 2

[:Gijs (he/him)]

Attachment: Data review request

Comment 3

[Tim Smith (inactive) 👨‍🔬 [:tdsmith]]

Comment on attachment 9198312 [details]
Data review request

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

Yes, in the probe definition files and the Probe Dictionary.

2. Is there a control mechanism that allows the user to turn the data collection on and off?

Yes, the Firefox telemetry opt-out.

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

n/a, temporary collection

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Cat 1

5. Is the data collection request for default-on or default-off?

Default-on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

Nope

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does there need to be a check-in in the future to determine whether to renew the data?

Gijs et al will renew as required.

9. Does the data collection use a third-party collection tool?

No.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09beb66ab605
measure paint delay induced by initializing bookmarks toolbar later, r=mconley

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

Backed out 2 changesets (bug 1680216, bug 1681138) for browser_984455_bookmarks_items_reparenting.js failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&selectedTaskRun=D9O_VLW_Q0S6QCWOOkdi6Q.0&fromchange=67e673da78c5d876a49e28c31d068ba3e1d08e5d&searchStr=windows%2C10%2Cx64%2Cwebrender%2Cdebug%2Cmochitests%2Ctest-windows10-64-qr%2Fdebug-mochitest-browser-chrome-e10s%2Cbc1&tochange=85d196d4bbd3406d0f06baf1010b07a9525d30aa

Backout link: https://hg.mozilla.org/integration/autoland/rev/85d196d4bbd3406d0f06baf1010b07a9525d30aa

Failure log: https://treeherder.mozilla.org/logviewer?job_id=327432509&repo=autoland&lineNumber=14220

...
[task 2021-01-22T01:48:31.200Z] 01:48:31     INFO - Entering test bound testOverflowingBookmarksItemsContextMenu
[task 2021-01-22T01:48:31.200Z] 01:48:31     INFO - Ensuring panel is ready.
[task 2021-01-22T01:48:31.200Z] 01:48:31     INFO - Buffered messages logged at 01:48:31
[task 2021-01-22T01:48:31.200Z] 01:48:31     INFO - Waiting for context menu on personal-bookmarks
[task 2021-01-22T01:48:31.200Z] 01:48:31     INFO - Buffered messages finished
[task 2021-01-22T01:48:31.200Z] 01:48:31     INFO - TEST-UNEXPECTED-FAIL | browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js | uncaught exception - TypeError: can't access property "buildContextMenu", menupopup._view is null at placesContextShowing@resource:///modules/PlacesUIUtils.jsm:1350:5
[task 2021-01-22T01:48:31.200Z] 01:48:31     INFO - onpopupshowing@chrome://browser/content/browser.xhtml:1:22
[task 2021-01-22T01:48:31.200Z] 01:48:31     INFO - synthesizeMouseAtPoint@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:594:32
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - synthesizeMouse@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:526:10
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - synthesizeMouseAtCenter@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:701:10
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - checkPlacesContextMenu/<@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:47:16
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - checkPlacesContextMenu@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:60:5
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - testOverflowingBookmarksItemsContextMenu@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:244:9
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - 
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - Stack trace:
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:simpletestOnerror:2112
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtPoint:594
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouse:526
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - chrome://mochikit/content/tests/SimpleTest/EventUtils.js:synthesizeMouseAtCenter:701
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:checkPlacesContextMenu/<:47
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:checkPlacesContextMenu:60
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:testOverflowingBookmarksItemsContextMenu:244
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - GECKO(9900) | JavaScript error: resource:///modules/PlacesUIUtils.jsm, line 1350: TypeError: can't access property "buildContextMenu", menupopup._view is null
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - Console message: [JavaScript Error: "TypeError: can't access property "buildContextMenu", menupopup._view is null" {file: "resource:///modules/PlacesUIUtils.jsm" line: 1350}]
[task 2021-01-22T01:48:31.201Z] 01:48:31     INFO - placesContextShowing@resource:///modules/PlacesUIUtils.jsm:1350:5
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - onpopupshowing@chrome://browser/content/browser.xhtml:1:22
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - synthesizeMouseAtPoint@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:594:32
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - synthesizeMouse@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:526:10
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - synthesizeMouseAtCenter@chrome://mochikit/content/tests/SimpleTest/EventUtils.js:701:10
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - checkPlacesContextMenu/<@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:47:16
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - checkPlacesContextMenu@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:60:5
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - testOverflowingBookmarksItemsContextMenu@chrome://mochitests/content/browser/browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js:244:9
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - 
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - TEST-PASS | browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js | New bookmark item shouldn't be disabled - 
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - Closing context menu
[task 2021-01-22T01:48:31.202Z] 01:48:31     INFO - Waiting for overflow
[task 2021-01-22T01:48:31.220Z] 01:48:31     INFO - GECKO(9900) | [Child 2772, Main Thread] WARNING: Scrolled rect smaller than scrollport?: file /builds/worker/checkouts/gecko/layout/generic/nsGfxScrollFrame.cpp:6984
[task 2021-01-22T01:48:31.220Z] 01:48:31     INFO - GECKO(9900) | [Child 2772, Main Thread] WARNING: Scrolled rect smaller than scrollport?: file /builds/worker/checkouts/gecko/layout/generic/nsGfxScrollFrame.cpp:6984
[task 2021-01-22T01:48:31.220Z] 01:48:31     INFO - GECKO(9900) | [Child 2772, Main Thread] WARNING: Scrolled rect smaller than scrollport?: file /builds/worker/checkouts/gecko/layout/generic/nsGfxScrollFrame.cpp:6984
[task 2021-01-22T01:48:31.305Z] 01:48:31     INFO - TEST-PASS | browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js | Item with ID personal-bookmarks should no longer be in the gNavBar - 
[task 2021-01-22T01:48:31.305Z] 01:48:31     INFO - TEST-PASS | browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js | Item with ID personal-bookmarks should be overflowing - 
[task 2021-01-22T01:48:31.305Z] 01:48:31     INFO - TEST-PASS | browser/components/customizableui/test/browser_984455_bookmarks_items_reparenting.js | Item with ID personal-bookmarks should have overflowedItem attribute - 
[task 2021-01-22T01:48:31.309Z] 01:48:31     INFO - Waiting until we stop overflowing
...

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/019d689bcd88
measure paint delay induced by initializing bookmarks toolbar later, r=mconley

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/019d689bcd88