1680218 - Remove backward compatibility code for server 80 to 83

Status: RESOLVED FIXED

(DevTools :: General, task)

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680218 - [devtools] Remove supportsNodePicker trait. r=rcaliman.

The trait was introduced in Firefox 80, so it's
safe to remove it now.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680218 - [devtools] Remove getAttributesInOwnerDocument trait. r=rcaliman.

The trait was introduced in Firefox 80, so it's
safe to remove it now.

Depends on D98487

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680218 - [devtools] Remove supportsIsTopLevelDocument trait. r=rcaliman.

The trait was introduced in Firefox 81, so it's
safe to remove it now.

Depends on D98488

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680218 - [devtools] Remove backward compatibility code for StyleSheetsFront#getTraits. r=rcaliman.

Depends on D98489

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680218 - [devtools] Remove supportResourceRequests trait in StyleSheetActor. r=daisuke.

The trait was added in 81, so we can safely remove it now.

Depends on D98490

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680218 - [devtools] Remove isFileNameSupported trait in StyleSheetActor. r=daisuke.

The trait was added in 81, so we can safely remove it now.

Depends on D98491

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680218 - [devtools] Remove unused methods in StyleSheetActor spec. r=daisuke,jdescottes.

Depends on D98493

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680218 - [devtools] Remove handling of old markup mutations. r=rcaliman.

frameLoad and documentUnload aren't emitted anymore (since 81),
so we can remove the code that was handling them.

Depends on D98494

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680218 - [devtools] Remove mentions of WorkerDescriptorActor#connect. r=ochameau.

The function doesn't exist anymore on newer server, so
we can remove it from the spec file.

Depends on D98495

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680218 - [devtools] Remove supportsOverflowDebugging2 trait. r=rcaliman.

The trait was added in Firefox 83, so we can safely
remove it now.

Depends on D98496

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680218 - [devtools] Remove PreferenceActor traits. r=jdescottes.

The trait were added in 81 and 82, so we can safely remove them now.
We take this opportunity to bail early in setDefaultpreferencesIfNeeded
when there's no default preferences to set.

Depends on D98497

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/936c49ae59a4
[devtools] Remove supportsNodePicker trait. r=rcaliman.
https://hg.mozilla.org/integration/autoland/rev/34838b56270b
[devtools] Remove getAttributesInOwnerDocument trait. r=rcaliman.
https://hg.mozilla.org/integration/autoland/rev/5103a959e33d
[devtools] Remove supportsIsTopLevelDocument trait. r=rcaliman.
https://hg.mozilla.org/integration/autoland/rev/37adf02276eb
[devtools] Remove backward compatibility code for StyleSheetsFront#getTraits. r=rcaliman.
https://hg.mozilla.org/integration/autoland/rev/d09c87a11d72
[devtools] Remove supportResourceRequests trait in StyleSheetActor. r=daisuke.
https://hg.mozilla.org/integration/autoland/rev/63d5d5fb0feb
[devtools] Remove isFileNameSupported trait in StyleSheetActor. r=daisuke.
https://hg.mozilla.org/integration/autoland/rev/082988607e17
[devtools] Remove unused methods in StyleSheetActor spec. r=daisuke,devtools-backward-compat-reviewers,jdescottes
https://hg.mozilla.org/integration/autoland/rev/9e668aa17d1c
[devtools] Remove handling of old markup mutations. r=rcaliman.
https://hg.mozilla.org/integration/autoland/rev/58034e6bc337
[devtools] Remove mentions of WorkerDescriptorActor#connect. r=ochameau,devtools-backward-compat-reviewers.
https://hg.mozilla.org/integration/autoland/rev/2cbd9d935611
[devtools] Remove supportsOverflowDebugging2 trait. r=rcaliman.
https://hg.mozilla.org/integration/autoland/rev/a17c7da1221c
[devtools] Remove PreferenceActor traits. r=jdescottes.

Comment 13

[Natalia Csoregi [:nataliaCs]]

Backed out for causing devtools failures e.g. /browser_rules_add-rule-and-property.js

backout: https://hg.mozilla.org/integration/autoland/rev/5138f2229279eafdac1d7027e9070b57236b4d01

push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=a17c7da1221c99514aee48e7bdd9dded64616913&searchStr=devtools&selectedTaskRun=Zeg9AQ_XTGyXI7qeuihjdQ.0

failures:

• https://treeherder.mozilla.org/logviewer?job_id=324015426&repo=autoland&lineNumber=4593
• https://treeherder.mozilla.org/logviewer?job_id=324015431&repo=autoland&lineNumber=20013

Comment 14

[Nicolas Chevobbe [:nchevobbe]]

I fixed the issue and TRY seems happy: https://treeherder.mozilla.org/jobs?repo=try&revision=b7196d0740dad61fdd929d1a300f2a1add59ff85&selectedTaskRun=IZo0nyRLTXK5-3K8FsaCQQ.0

I'll land the patch again

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d97898adb430
[devtools] Remove supportsNodePicker trait. r=rcaliman.
https://hg.mozilla.org/integration/autoland/rev/30479fbcfa4b
[devtools] Remove getAttributesInOwnerDocument trait. r=rcaliman.
https://hg.mozilla.org/integration/autoland/rev/d30fc20d368f
[devtools] Remove supportsIsTopLevelDocument trait. r=rcaliman.
https://hg.mozilla.org/integration/autoland/rev/e221b00f778a
[devtools] Remove backward compatibility code for StyleSheetsFront#getTraits. r=rcaliman.
https://hg.mozilla.org/integration/autoland/rev/74a6648f88a9
[devtools] Remove supportResourceRequests trait in StyleSheetActor. r=daisuke.
https://hg.mozilla.org/integration/autoland/rev/ceeec929b841
[devtools] Remove isFileNameSupported trait in StyleSheetActor. r=daisuke.
https://hg.mozilla.org/integration/autoland/rev/dc1c70208f05
[devtools] Remove unused methods in StyleSheetActor spec. r=daisuke,devtools-backward-compat-reviewers,jdescottes.
https://hg.mozilla.org/integration/autoland/rev/ff1c6617fea5
[devtools] Remove handling of old markup mutations. r=rcaliman.
https://hg.mozilla.org/integration/autoland/rev/025e45f7d6ad
[devtools] Remove mentions of WorkerDescriptorActor#connect. r=ochameau,devtools-backward-compat-reviewers.
https://hg.mozilla.org/integration/autoland/rev/a5c3834ef2c5
[devtools] Remove supportsOverflowDebugging2 trait. r=rcaliman.
https://hg.mozilla.org/integration/autoland/rev/955341cf5839
[devtools] Remove PreferenceActor traits. r=jdescottes.

Comment 16

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/d97898adb430
https://hg.mozilla.org/mozilla-central/rev/30479fbcfa4b
https://hg.mozilla.org/mozilla-central/rev/d30fc20d368f
https://hg.mozilla.org/mozilla-central/rev/e221b00f778a
https://hg.mozilla.org/mozilla-central/rev/74a6648f88a9
https://hg.mozilla.org/mozilla-central/rev/ceeec929b841
https://hg.mozilla.org/mozilla-central/rev/dc1c70208f05
https://hg.mozilla.org/mozilla-central/rev/ff1c6617fea5
https://hg.mozilla.org/mozilla-central/rev/025e45f7d6ad
https://hg.mozilla.org/mozilla-central/rev/a5c3834ef2c5
https://hg.mozilla.org/mozilla-central/rev/955341cf5839