1680241 - script-source-extent.js test is sensitive to GC timing

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jon Coppeard (:jonco)]

While working on bug 1677765 I found that if a GC occurs in the wrong place then this test can fail.

For example, if I add a gc() call after g.evaluate in getScriptSourceExtent, it fails like this:

/Users/jon/work/bug/js/src/jit-test/tests/parser/script-source-extent.js:78:13 Error: Assertion failed: got 1, expected 2
Stack:
  testSourceExtent@/Users/jon/work/bug/js/src/jit-test/tests/parser/script-source-extent.js:78:13
  @/Users/jon/work/bug/js/src/jit-test/tests/parser/script-source-extent.js:240:17

Comment 1

[Jon Coppeard (:jonco)]

My guess is that some static class field initializer lambdas are no longer reachable after the class has been initialised and are thrown away by GC.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1680241 - Disable GC zeal in script-source-extent.js test r?tcampbell

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e3d78b6d7755
Disable GC zeal in script-source-extent.js test r=tcampbell

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/e3d78b6d7755