1680258 - Enable Pre-XUL skeleton UI on Nightly

Status: RESOLVED FIXED

(Firefox :: General, task)

Comment 1

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1680258 - Improve skeleton UI arg checking for marionette

Previously, we implemented arg checking with marionette just carrying a free
pass, so we could let the arguments which typically come when running tests.
However, some marionette tests do like to play with arguments which we do not
want to get a free pass, such as -safe-mode. These changes allow just the
-profile argument through, as that is necessary for running tests.

Comment 2

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1680258 - Check for problematic env vars for skeleton UI

Some env vars have effects similar to command line arguments which present
problems for the skeleton UI, and we want to treat these env vars similarly.

Depends on D98474

Comment 3

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1680258 - Don't try to draw rects with 0 width or height r?emalysz

This prevents an assertion from tripping below.

Depends on D98475

Comment 4

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1680258 - Change first paint notification event when skele UI enabled r?florian

Having the window present earlier changes the ordering of these events, such
that it doesn't come through at the time that the browser_startup test needs it
to. I think this event should be correct anyway, given that we already painted
the skeleton UI?

Depends on D98476

Comment 5

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1680258 - Ensure UI state initialized for skeleton UI

This was causing us to have slightly wrong focusring behavior, leading to wpt
failures in focus-visible-005.html.

Depends on D98478

Comment 6

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1680258 - Enable skeleton UI on nightly

Depends on D98479

Comment 7

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1680258 - Ensure we properly clamp values to draw region

Depends on D98479

Comment 8

[Alex Thayer [:alexical] (she/her)]

Attachment: Bug 1680258 - Relax startup IPC test for skeleton UI due to paint timings r?florian

I don't have a crystal clear story of why these timings are different with the
skeleton UI enabled. However, it's not remarkably surprising that it changes the
order of some events during startup which come from the core Windows event loop.
I don't think it's worth diving incredibly deep to understand this - looking at
the profile we still only see one of each of these events.

Depends on D99110

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9b9f97caa6c
Improve skeleton UI arg checking for marionette r=Gijs
https://hg.mozilla.org/integration/autoland/rev/268d2aac128e
Check for problematic env vars for skeleton UI r=Gijs
https://hg.mozilla.org/integration/autoland/rev/183d89827d4b
Don't try to draw rects with 0 width or height r=emalysz
https://hg.mozilla.org/integration/autoland/rev/a253801a3155
Change first paint notification event when skele UI enabled r=florian
https://hg.mozilla.org/integration/autoland/rev/403d7441eb0c
Ensure UI state initialized for skeleton UI r=mhowell
https://hg.mozilla.org/integration/autoland/rev/8eb4ebbd13d0
Ensure we properly clamp values to draw region r=mstange
https://hg.mozilla.org/integration/autoland/rev/4b885b40c787
Relax startup IPC test for skeleton UI due to paint timings r=florian

Comment 10

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a4dc1badd9c7
Backed out 7 changesets for causing osx mochitest timeouts.

Comment 11

[Alexandru Michis [:malexandru]]

Backed out 7 changesets (Bug 1680258) for causing osx mochitest timeouts.

Backout link: https://hg.mozilla.org/integration/autoland/rev/a4dc1badd9c732408e6c7d4204524b6afa92c0ed

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Csuccess%2Cretry%2Crunnable&fromchange=7841de92cf8263a44b4395e4ec56c4099eb841d0&searchStr=osx&tochange=1359af4d35d17f5db3e8e35e34e2f86d2a5b4ea2&selectedTaskRun=DaLnBIq9TkqCh_nT4lX3MQ.0

Failure logs:

• wpt: https://treeherder.mozilla.org/logviewer?job_id=324079445&repo=autoland&lineNumber=1002
• webgl: https://treeherder.mozilla.org/logviewer?job_id=324079348&repo=autoland&lineNumber=1678
• bc: https://treeherder.mozilla.org/logviewer?job_id=324075233&repo=autoland&lineNumber=1448
• jreftest: https://treeherder.mozilla.org/logviewer?job_id=324078424&repo=autoland&lineNumber=1609

Comment 12

[Alex Thayer [:alexical] (she/her)]

I'm very confused by this? None of this is even compiled on OSX.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b2ec458a63aa
Improve skeleton UI arg checking for marionette r=Gijs
https://hg.mozilla.org/integration/autoland/rev/b937607a2086
Check for problematic env vars for skeleton UI r=Gijs
https://hg.mozilla.org/integration/autoland/rev/dc51252ef65c
Don't try to draw rects with 0 width or height r=emalysz
https://hg.mozilla.org/integration/autoland/rev/4b8533805da7
Change first paint notification event when skele UI enabled r=florian
https://hg.mozilla.org/integration/autoland/rev/3c29ebb65840
Ensure UI state initialized for skeleton UI r=mhowell
https://hg.mozilla.org/integration/autoland/rev/00e863166a86
Ensure we properly clamp values to draw region r=mstange
https://hg.mozilla.org/integration/autoland/rev/4f79a1f41723
Relax startup IPC test for skeleton UI due to paint timings r=florian

Comment 14

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b2ec458a63aa
https://hg.mozilla.org/mozilla-central/rev/b937607a2086
https://hg.mozilla.org/mozilla-central/rev/dc51252ef65c
https://hg.mozilla.org/mozilla-central/rev/4b8533805da7
https://hg.mozilla.org/mozilla-central/rev/3c29ebb65840
https://hg.mozilla.org/mozilla-central/rev/00e863166a86
https://hg.mozilla.org/mozilla-central/rev/4f79a1f41723

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5bcb9f8eab9
Enable skeleton UI on nightly r=mhowell

Comment 16

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c5bcb9f8eab9