1680275 - Change some global tables used by quota clients to utilize NotNull

Status: RESOLVED FIXED

(Core :: Storage: Quota Manager, task, P2)

Description

[Jan Varga [:janv]]

This was raised in D98344. Currently we have some assertions to make sure pointers are not null, especially during iteration over the tables. NotNull would simplify it and also improve the safety.

Comment 1

[Jan Varga [:janv]]

Attachment: Bug 1680275 - IDB: Change DatabaseActorInfo::mLiveDatabases to use NotNull; r=#dom-workers-and-storage-reviewers

Depends on D98609

Comment 2

[Jan Varga [:janv]]

Attachment: Bug 1680275 - DOMCACHE: Change Manager::Factory::mManagerList to use NotNull; r=#dom-workers-and-storage-reviewers

Depends on D98717

Comment 3

[Jan Varga [:janv]]

Attachment: Bug 1680275 - SDB: Change gOpenConnections to use NotNull; r=#dom-workers-and-storage-reviewers

Depends on D98718

Comment 4

[Jan Varga [:janv]]

Attachment: Bug 1680275 - LSNG: Change gPrepareDatastoreOps and gLiveDatabases to use NotNull; r=#dom-workers-and-storage-reviewers

Depends on D98719

Comment 5

[Jan Varga [:janv]]

Attachment: Bug 1680275 - LSNG: Change gDatastores to use NotNull; r=#dom-workers-and-storage-reviewers

Depends on D99197

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c7d7fcbde0f1
IDB: Change DatabaseActorInfo::mLiveDatabases to use NotNull; r=dom-workers-and-storage-reviewers,sg

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48d49c538973
DOMCACHE: Change Manager::Factory::mManagerList to use NotNull; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/2bd0618c0170
SDB: Change gOpenConnections to use NotNull; r=dom-workers-and-storage-reviewers,sg
https://hg.mozilla.org/integration/autoland/rev/4f5b7327446c
LSNG: Change gPrepareDatastoreOps and gLiveDatabases to use NotNull; r=dom-workers-and-storage-reviewers,sg

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/c7d7fcbde0f1

Comment 9

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/48d49c538973
https://hg.mozilla.org/mozilla-central/rev/2bd0618c0170
https://hg.mozilla.org/mozilla-central/rev/4f5b7327446c

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/005c38c7c0d5
LSNG: Change gDatastores to use NotNull; r=dom-workers-and-storage-reviewers,sg

Comment 11

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/005c38c7c0d5