Closed
Bug 168029
Opened 22 years ago
Closed 22 years ago
Bug 22056 checkin regressed Ts and Txul
Categories
(SeaMonkey :: Preferences, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: bzbarsky, Assigned: neil)
References
()
Details
(Keywords: regression, smoketest)
The patch for bug 22056 regressed Ts by what looks like 1.5% and Txul by 5%. If we can't fix that in the very near term, I think we should back the patch out... (much as it pains me to say that). I strongly suspect that the problem is that the new CSS rules are not exactly the fastest things in the world... Could we maybe make the toolbarmode a class instead of an attribute? So change: +.toolbarbutton-1[toolbarmode="small"] to +.toolbarbutton-1.toolbarmode-small That seems like it would make the switching code more complicated, but the switches won't happen that often anyway...
Comment 1•22 years ago
|
||
http://mozilla.org/hacking/regression-policy.html is quite clear. If this can't be fixed in an hour, it should be backed out. Cc'ing Asa. You probably have a couple of hours, given the state of the tree, but without a quick and convincing fix that restores the lost perf, the patch for bug 22056 must come out of the trunk. /be
Comment 2•22 years ago
|
||
neil: any progresss on this?
Comment 3•22 years ago
|
||
so is this being backed out? yes/no? The trunk's ready to be opened, but If you're going to back out, you have my permission to do so.
Reporter | ||
Comment 5•22 years ago
|
||
I'm selectively backing out just the CSS as we speak. That will at least tell us what's going on.
Reporter | ||
Comment 6•22 years ago
|
||
I've backed the whole patch out, since the CSS backout only recovered half the lost time.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Comment 7•22 years ago
|
||
ReOpening. I see perf improvements; but not there yet. After Boris rolled back, we see Txul = 1214 Ts = 3276 However, last night we had Txul = 1179 Ts = 3214
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 8•22 years ago
|
||
I results are from "Linux luna Dep" tinderbox
Comment 9•22 years ago
|
||
Actually, there were two separate (in time and code) regressions for Ts/Txul in the past 24 hours. bz has backed out the code for the second regression which was being tracked by this bug report. Hence, this bug is fixed. The earlier regression is being tracked on bug 167929.
Status: REOPENED → RESOLVED
Closed: 22 years ago → 22 years ago
Resolution: --- → FIXED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•