Closed Bug 1680292 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 26721 - Restrict code points allowed in extensions

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox85 fixed)

Status:
RESOLVED FIXED
Milestone:
85 Branch
Tracking Flags:
Tracking Status
firefox85 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 26721 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/26721
Details from upstream follow.

b'Austin Sullivan <asully@chromium.org>' wrote:

Restrict code points allowed in extensions

Existing restriction:

  • Must start with "."

New restrictions:

  • Allowed code points: A-Za-z0-9+.
  • Restrict length to 16 code points
  • Cannot end with "."

Bug: 1137247, 1140410, 1140417
Change-Id: I593f7ca60e05177402885bd3026add16b3a07d0c
Reviewed-on: https://chromium-review.googlesource.com/2568534
WPT-Export-Revision: c3362556662ce0333e16d036ead64d54cc21c2a8

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 61 subtests

Status Summary

Firefox

OK : 1
FAIL: 61

Chrome

OK : 1
PASS: 25
FAIL: 36

Safari

OK : 1
FAIL: 61

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/native-file-system/showPicker-errors.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
showOpenFilePicker: Showing a picker requires user activation.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: Showing a picker requires user activation.: FAIL (Chrome: PASS, Safari: FAIL)
showDirectoryPicker: Showing a picker requires user activation.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: File picker requires at least one accepted type.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: MIME type can't be an empty string.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: MIME type must have subtype.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: MIME type can't have empty type.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: MIME type can't have empty subtype.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: MIME type can't have parameters.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: MIME type can't have invalid characters in type.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: MIME type can't have whitespace in the middle.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: MIME type can't have invalid characters in subtype.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".extensiontoolong". extension length more than 16..: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension ".txt.". extenstion ends with ".".: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension "txt". extenstion does not start with ".".: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ".$txt". illegal character "$".: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension ".t<xt". illegal character "<".: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension ".t/xt". illegal character "".: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension ". xt". illegal character "/".: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension ".txt". illegal characters "".: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension ".txt?". illegal character "?".: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension ".txt*". illegal character "".: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension ".{txt". illegal character "{".: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension ".}txt". illegal character "}".: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension " .txt". illegal whitespace at front of extension.: FAIL (Chrome: PASS, Safari: FAIL)
showOpenFilePicker: invalid extension ". txt". illegal whitespace in extension.: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension ".txt ". illegal whitespace at end of extension.: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension ".‮txt‮". illegal RTL character.: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension ".tæxt". non-ASCII character "æ".: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension ".קום". non-ASCII character "קום".: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension ".txt🙂". non-ASCII character "🙂".: FAIL (Chrome: FAIL, Safari: FAIL)
showOpenFilePicker: invalid extension ".{txt}". illegal characters "{" and "}".: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: File picker requires at least one accepted type.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: MIME type can't be an empty string.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: MIME type must have subtype.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: MIME type can't have empty type.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: MIME type can't have empty subtype.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: MIME type can't have parameters.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: MIME type can't have invalid characters in type.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: MIME type can't have whitespace in the middle.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: MIME type can't have invalid characters in subtype.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".extensiontoolong". extension length more than 16..: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension ".txt.". extenstion ends with ".".: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension "txt". extenstion does not start with ".".: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ".$txt". illegal character "$".: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension ".t<xt". illegal character "<".: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension ".t/xt". illegal character "".: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension ". xt". illegal character "/".: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension ".txt". illegal characters "".: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension ".txt?". illegal character "?".: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension ".txt". illegal character "*".: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension ".{txt". illegal character "{".: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension ".}txt". illegal character "}".: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension " .txt". illegal whitespace at front of extension.: FAIL (Chrome: PASS, Safari: FAIL)
showSaveFilePicker: invalid extension ". txt". illegal whitespace in extension.: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension ".txt ". illegal whitespace at end of extension.: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension ".txt". illegal RTL character.: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension ".tæxt". non-ASCII character "æ".: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension ".קום". non-ASCII character "קום".: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension ".txt🙂". non-ASCII character "🙂".: FAIL (Chrome: FAIL, Safari: FAIL)
showSaveFilePicker: invalid extension ".{txt}". illegal characters "{" and "}".: FAIL (Chrome: FAIL, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/native-file-system/showPicker-errors.https.window.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4bcc7b884a6a
[wpt PR 26721] - Add restrictions to allowed extensions for File System Access API, a=testonly

https://hg.mozilla.org/mozilla-central/rev/4bcc7b884a6a

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox85: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
You need to log in before you can comment on or make changes to this bug.