Closed Bug 1680406 Opened 3 years ago Closed 3 years ago

Assertion failure: nif || !nifNeedPushedItem || mDidPushItemsBitMayLie (The state bit stored in didPushItemsBit lied!), at src/layout/generic/nsContainerFrame.cpp:1956

Categories

(Core :: Layout, defect, P3)

Product:
Core
Component:
Layout
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
86 Branch
Tracking Flags:
Tracking Status
firefox-esr78 --- wontfix
firefox83 --- wontfix
firefox84 --- wontfix
firefox85 --- wontfix
firefox86 --- verified

People

(Reporter: tsmith, Assigned: MatsPalmgren_bugz)

References

(Blocks 1 open bug, Regressed 1 open bug, Regression)

Details

(Keywords: assertion, regression, testcase, Whiteboard: [bugmon:bisected,confirmed])

Attachments

(2 files)

testcase.html
198 bytes, text/html
Details
Bug 1680406 - Allow a prev-in-flow to have an ExcessOverflowContainers list and merge it to our OverflowContainers as needed. r=TYLin
47 bytes, text/x-phabricator-request
Details | Review
Attached file testcase.html —

Assertion failure: nif || !nifNeedPushedItem || mDidPushItemsBitMayLie (The state bit stored in didPushItemsBit lied!), at src/layout/generic/nsContainerFrame.cpp:1956

#0 0x7f95c2f0866f in nsContainerFrame::NormalizeChildLists() src/layout/generic/nsContainerFrame.cpp:1955:7
#1 0x7f95c2f1cad4 in nsFlexContainerFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsFlexContainerFrame.cpp:4362:3
#2 0x7f95c2f03ad0 in nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, mozilla::WritingMode const&, mozilla::LogicalPoint const&, nsSize const&, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) src/layout/generic/nsContainerFrame.cpp:1082:14
#3 0x7f95c2f20de3 in nsFlexContainerFrame::ReflowFlexItem(nsFlexContainerFrame::FlexboxAxisTracker const&, mozilla::ReflowInput const&, nsFlexContainerFrame::FlexItem const&, mozilla::LogicalPoint&, mozilla::LogicalSize const&, nsSize const&, bool) src/layout/generic/nsFlexContainerFrame.cpp:5484:3
#4 0x7f95c2f1f7d4 in nsFlexContainerFrame::ReflowChildren(mozilla::ReflowInput const&, int, int, mozilla::LogicalSize const&, mozilla::LogicalMargin const&, int, int&, nsTArray<nsFlexContainerFrame::FlexLine>&, nsTArray<nsIFrame*>&, nsFlexContainerFrame::FlexboxAxisTracker const&, bool) src/layout/generic/nsFlexContainerFrame.cpp:5158:13
#5 0x7f95c2f1d43e in nsFlexContainerFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsFlexContainerFrame.cpp:4501:7
#6 0x7f95c2f03ad0 in nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, mozilla::WritingMode const&, mozilla::LogicalPoint const&, nsSize const&, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) src/layout/generic/nsContainerFrame.cpp:1082:14
#7 0x7f95c2f04b89 in nsContainerFrame::ReflowOverflowContainerChildren(nsPresContext*, mozilla::ReflowInput const&, mozilla::OverflowAreas&, nsIFrame::ReflowChildFlags, nsReflowStatus&, void (*)(nsFrameList&, nsFrameList&, nsContainerFrame*), mozilla::Maybe<nsSize>) src/layout/generic/nsContainerFrame.cpp:1349:7
#8 0x7f95c2ecd277 in nsBlockFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsBlockFrame.cpp:1342:5
#9 0x7f95c2f03ad0 in nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, mozilla::WritingMode const&, mozilla::LogicalPoint const&, nsSize const&, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) src/layout/generic/nsContainerFrame.cpp:1082:14
#10 0x7f95c2ef4686 in nsColumnSetFrame::ReflowChildren(mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&, nsColumnSetFrame::ReflowConfig const&, bool) src/layout/generic/nsColumnSetFrame.cpp:692:7
#11 0x7f95c2ef63de in ReflowColumns src/layout/generic/nsColumnSetFrame.cpp:403:37
#12 0x7f95c2ef63de in nsColumnSetFrame::FindBestBalanceBSize(mozilla::ReflowInput const&, nsPresContext*, nsColumnSetFrame::ReflowConfig&, nsColumnSetFrame::ColumnBalanceData, mozilla::ReflowOutput&, bool, nsReflowStatus&) src/layout/generic/nsColumnSetFrame.cpp:1186:5
#13 0x7f95c2ef67f0 in nsColumnSetFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsColumnSetFrame.cpp:1241:5
#14 0x7f95c2edbd40 in nsBlockReflowContext::ReflowBlock(mozilla::LogicalRect const&, bool, nsCollapsingMargin&, int, bool, nsLineBox*, mozilla::ReflowInput&, nsReflowStatus&, mozilla::BlockReflowInput&) src/layout/generic/nsBlockReflowContext.cpp:288:11
#15 0x7f95c2ed7f19 in nsBlockFrame::ReflowBlockFrame(mozilla::BlockReflowInput&, nsLineList_iterator, bool*) src/layout/generic/nsBlockFrame.cpp:3846:11
#16 0x7f95c2ed5c76 in nsBlockFrame::ReflowLine(mozilla::BlockReflowInput&, nsLineList_iterator, bool*) src/layout/generic/nsBlockFrame.cpp:3182:5
#17 0x7f95c2ed0cbf in nsBlockFrame::ReflowDirtyLines(mozilla::BlockReflowInput&) src/layout/generic/nsBlockFrame.cpp:2719:7
#18 0x7f95c2ecd449 in nsBlockFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsBlockFrame.cpp:1376:3
#19 0x7f95c2f03ad0 in nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, mozilla::WritingMode const&, mozilla::LogicalPoint const&, nsSize const&, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) src/layout/generic/nsContainerFrame.cpp:1082:14
#20 0x7f95c2f20de3 in nsFlexContainerFrame::ReflowFlexItem(nsFlexContainerFrame::FlexboxAxisTracker const&, mozilla::ReflowInput const&, nsFlexContainerFrame::FlexItem const&, mozilla::LogicalPoint&, mozilla::LogicalSize const&, nsSize const&, bool) src/layout/generic/nsFlexContainerFrame.cpp:5484:3
#21 0x7f95c2f1f7d4 in nsFlexContainerFrame::ReflowChildren(mozilla::ReflowInput const&, int, int, mozilla::LogicalSize const&, mozilla::LogicalMargin const&, int, int&, nsTArray<nsFlexContainerFrame::FlexLine>&, nsTArray<nsIFrame*>&, nsFlexContainerFrame::FlexboxAxisTracker const&, bool) src/layout/generic/nsFlexContainerFrame.cpp:5158:13
#22 0x7f95c2f1d43e in nsFlexContainerFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsFlexContainerFrame.cpp:4501:7
#23 0x7f95c2f03ad0 in nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, mozilla::WritingMode const&, mozilla::LogicalPoint const&, nsSize const&, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) src/layout/generic/nsContainerFrame.cpp:1082:14
#24 0x7f95c2f15ac3 in nsFlexContainerFrame::MeasureAscentAndBSizeForFlexItem(nsFlexContainerFrame::FlexItem&, mozilla::ReflowInput&) src/layout/generic/nsFlexContainerFrame.cpp:1921:3
#25 0x7f95c2f15390 in nsFlexContainerFrame::MeasureFlexItemContentBSize(nsFlexContainerFrame::FlexItem&, bool, bool, mozilla::ReflowInput const&) src/layout/generic/nsFlexContainerFrame.cpp:1990:7
#26 0x7f95c2f14cc1 in nsFlexContainerFrame::ResolveAutoFlexBasisAndMinSize(nsFlexContainerFrame::FlexItem&, mozilla::ReflowInput const&, nsFlexContainerFrame::FlexboxAxisTracker const&, bool) src/layout/generic/nsFlexContainerFrame.cpp:1659:11
#27 0x7f95c2f14183 in nsFlexContainerFrame::GenerateFlexItemForChild(nsFlexContainerFrame::FlexLine&, nsIFrame*, mozilla::ReflowInput const&, nsFlexContainerFrame::FlexboxAxisTracker const&, bool) src/layout/generic/nsFlexContainerFrame.cpp:1440:3
#28 0x7f95c2f1b2ae in nsFlexContainerFrame::GenerateFlexLines(mozilla::ReflowInput const&, int, nsTArray<nsFlexContainerFrame::StrutInfo> const&, nsFlexContainerFrame::FlexboxAxisTracker const&, int, bool, nsTArray<nsIFrame*>&, nsTArray<nsFlexContainerFrame::FlexLine>&) src/layout/generic/nsFlexContainerFrame.cpp:4010:7
#29 0x7f95c2f1e043 in nsFlexContainerFrame::DoFlexLayout(mozilla::ReflowInput const&, int&, int&, int&, nsTArray<nsFlexContainerFrame::FlexLine>&, nsTArray<nsFlexContainerFrame::StrutInfo>&, nsTArray<nsIFrame*>&, nsFlexContainerFrame::FlexboxAxisTracker const&, int, int, int, bool, ComputedFlexContainerInfo*) src/layout/generic/nsFlexContainerFrame.cpp:4889:3
#30 0x7f95c2f1d0be in nsFlexContainerFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsFlexContainerFrame.cpp:4446:5
#31 0x7f95c2f03ad0 in nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, mozilla::WritingMode const&, mozilla::LogicalPoint const&, nsSize const&, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) src/layout/generic/nsContainerFrame.cpp:1082:14
#32 0x7f95c2ef287d in nsCanvasFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsCanvasFrame.cpp:789:7
#33 0x7f95c2f03ad0 in nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, mozilla::WritingMode const&, mozilla::LogicalPoint const&, nsSize const&, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) src/layout/generic/nsContainerFrame.cpp:1082:14
#34 0x7f95c2f3d166 in nsHTMLScrollFrame::ReflowScrolledFrame(mozilla::ScrollReflowInput*, bool, bool, mozilla::ReflowOutput*) src/layout/generic/nsGfxScrollFrame.cpp:757:3
#35 0x7f95c2f3dbf9 in nsHTMLScrollFrame::ReflowContents(mozilla::ScrollReflowInput*, mozilla::ReflowOutput const&) src/layout/generic/nsGfxScrollFrame.cpp:881:3
#36 0x7f95c2f41bf7 in nsHTMLScrollFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/nsGfxScrollFrame.cpp:1279:3
#37 0x7f95c2f03f28 in nsContainerFrame::ReflowChild(nsIFrame*, nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, int, int, nsIFrame::ReflowChildFlags, nsReflowStatus&, nsOverflowContinuationTracker*) src/layout/generic/nsContainerFrame.cpp:1122:14
#38 0x7f95c2ec511b in mozilla::ViewportFrame::Reflow(nsPresContext*, mozilla::ReflowOutput&, mozilla::ReflowInput const&, nsReflowStatus&) src/layout/generic/ViewportFrame.cpp:339:7
#39 0x7f95c2dcdda6 in mozilla::PresShell::DoReflow(nsIFrame*, bool, mozilla::OverflowChangedTracker*) src/layout/base/PresShell.cpp:9673:11
#40 0x7f95c2dd757e in mozilla::PresShell::ProcessReflowCommands(bool) src/layout/base/PresShell.cpp:9846:24
#41 0x7f95c2dd6b44 in mozilla::PresShell::DoFlushPendingNotifications(mozilla::ChangesToFlush) src/layout/base/PresShell.cpp:4252:11
#42 0x7f95c2d9fb99 in FlushPendingNotifications /builds/worker/workspace/obj-build/dist/include/mozilla/PresShell.h:1413:5
#43 0x7f95c2d9fb99 in nsRefreshDriver::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) src/layout/base/nsRefreshDriver.cpp:2251:20
#44 0x7f95c2da7aa1 in TickDriver src/layout/base/nsRefreshDriver.cpp:375:13
#45 0x7f95c2da7aa1 in mozilla::RefreshDriverTimer::TickRefreshDrivers(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp, nsTArray<RefPtr<nsRefreshDriver> >&) src/layout/base/nsRefreshDriver.cpp:354:7
#46 0x7f95c2da798c in mozilla::RefreshDriverTimer::Tick(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) src/layout/base/nsRefreshDriver.cpp:369:5
#47 0x7f95c2da6f38 in RunRefreshDrivers src/layout/base/nsRefreshDriver.cpp:830:5
#48 0x7f95c2da6f38 in mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::TickRefreshDriver(mozilla::layers::BaseTransactionId<mozilla::VsyncIdType>, mozilla::TimeStamp) src/layout/base/nsRefreshDriver.cpp:748:16
#49 0x7f95c2da6840 in mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyParentProcessVsync() src/layout/base/nsRefreshDriver.cpp:650:7
#50 0x7f95c2da62b9 in mozilla::VsyncRefreshDriverTimer::RefreshDriverVsyncObserver::NotifyVsync(mozilla::VsyncEvent const&) src/layout/base/nsRefreshDriver.cpp:571:9
#51 0x7f95c31685a7 in mozilla::layout::VsyncChild::RecvNotify(mozilla::VsyncEvent const&) src/layout/ipc/VsyncChild.cpp:55:16
#52 0x7f95bf3e7205 in mozilla::layout::PVsyncChild::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PVsyncChild.cpp:194:54
#53 0x7f95bf191c1c in mozilla::ipc::PBackgroundChild::OnMessageReceived(IPC::Message const&) /builds/worker/workspace/obj-build/ipc/ipdl/PBackgroundChild.cpp:6256:32
#54 0x7f95bee56e3e in mozilla::ipc::MessageChannel::DispatchAsyncMessage(mozilla::ipc::ActorLifecycleProxy*, IPC::Message const&) src/ipc/glue/MessageChannel.cpp:2153:25
#55 0x7f95bee5355d in mozilla::ipc::MessageChannel::DispatchMessage(IPC::Message&&) src/ipc/glue/MessageChannel.cpp:2077:9
#56 0x7f95bee54a06 in mozilla::ipc::MessageChannel::RunMessage(mozilla::ipc::MessageChannel::MessageTask&) src/ipc/glue/MessageChannel.cpp:1925:3
#57 0x7f95bee5562b in mozilla::ipc::MessageChannel::MessageTask::Run() src/ipc/glue/MessageChannel.cpp:1956:13
#58 0x7f95be5430af in mozilla::RunnableTask::Run() src/xpcom/threads/TaskController.cpp:450:16
#59 0x7f95be54171a in mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) src/xpcom/threads/TaskController.cpp:720:26
#60 0x7f95be5407c4 in mozilla::TaskController::ExecuteNextTaskOnlyMainThreadInternal(mozilla::detail::BaseAutoLock<mozilla::Mutex&> const&) src/xpcom/threads/TaskController.cpp:579:15
#61 0x7f95be540977 in mozilla::TaskController::ProcessPendingMTTask(bool) src/xpcom/threads/TaskController.cpp:373:36
#62 0x7f95be546986 in operator() src/xpcom/threads/TaskController.cpp:120:37
#63 0x7f95be546986 in mozilla::detail::RunnableFunction<mozilla::TaskController::InitializeInternal()::$_3>::Run() /builds/worker/workspace/obj-build/dist/include/nsThreadUtils.h:485:5
#64 0x7f95be557f07 in nsThread::ProcessNextEvent(bool, bool*) src/xpcom/threads/nsThread.cpp:1196:14
#65 0x7f95be55dfaa in NS_ProcessNextEvent(nsIThread*, bool) src/xpcom/threads/nsThreadUtils.cpp:513:10
#66 0x7f95bee5c6d6 in mozilla::ipc::MessagePump::Run(base::MessagePump::Delegate*) src/ipc/glue/MessagePump.cpp:87:21
#67 0x7f95bedc9a43 in MessageLoop::RunInternal() src/ipc/chromium/src/base/message_loop.cc:334:10
#68 0x7f95bedc995d in RunHandler src/ipc/chromium/src/base/message_loop.cc:327:3
#69 0x7f95bedc995d in MessageLoop::Run() src/ipc/chromium/src/base/message_loop.cc:309:3
#70 0x7f95c2afb638 in nsBaseAppShell::Run() src/widget/nsBaseAppShell.cpp:137:27
#71 0x7f95c42f5083 in XRE_RunAppShell() src/toolkit/xre/nsEmbedFunctions.cpp:901:20
#72 0x7f95bee5d499 in mozilla::ipc::MessagePumpForChildProcess::Run(base::MessagePump::Delegate*) src/ipc/glue/MessagePump.cpp:237:9
#73 0x7f95bedc9a43 in MessageLoop::RunInternal() src/ipc/chromium/src/base/message_loop.cc:334:10
#74 0x7f95bedc995d in RunHandler src/ipc/chromium/src/base/message_loop.cc:327:3
#75 0x7f95bedc995d in MessageLoop::Run() src/ipc/chromium/src/base/message_loop.cc:309:3
#76 0x7f95c42f4c68 in XRE_InitChildProcess(int, char**, XREChildData const*) src/toolkit/xre/nsEmbedFunctions.cpp:732:34
#77 0x55dbcabb7a67 in content_process_main src/browser/app/../../ipc/contentproc/plugin-container.cpp:57:28
#78 0x55dbcabb7a67 in main src/browser/app/nsBrowserApp.cpp:305:18
#79 0x7f95d2d3e0b2 in __libc_start_main /build/glibc-ZN95T4/glibc-2.31/csu/../csu/libc-start.c:308:16
#80 0x55dbcab95819 in _start (/home/worker/builds/m-c-20201124212234-fuzzing-debug/firefox-bin+0x14819)
Flags: in-testsuite?

A Pernosco session is available here: https://pernos.co/debug/ZTcBg7sCe1seAwmNhT7mHw/index.html

Bugmon Analysis:
Verified bug as reproducible on mozilla-central 20201207093731-7167ab3f6e8d.
The bug appears to have been introduced in the following build range:

Start: 97855f04050aad83a2b4249edcffa282c9ad05ec (20200512181304)
End: 76aa4bf4eabd44912cc33a4ccd4d5474fc0e2ca7 (20200512181502)
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=97855f04050aad83a2b4249edcffa282c9ad05ec&tochange=76aa4bf4eabd44912cc33a4ccd4d5474fc0e2ca7

Whiteboard: [bugmon:bisected,confirmed]
Regressed by: 1622935
Has Regression Range: --- → yes

Regression from the flex fragmentation work. Ting-Yu, do you have cycles to take a look?

Flags: needinfo?(aethanyc)
Severity: -- → S3
Priority: -- → P3

The testcase triggers the following assertion in debug build before crashing in debug build.

###!!! ASSERTION: conflicting overflow containers lists: '!(overflowContainers && GetPrevInFlow() && static_cast<nsContainerFrame*>(GetPrevInFlow()) ->GetExcessOverflowContainers())', file /home/aethanyc/Projects/gecko/layout/generic/nsContainerFrame.cpp:2231

I'm keeping the assertion for now, but relaxing it to not apply
to Flex/Grid containers.

Assignee: nobody → mats
Status: NEW → ASSIGNED

Mats, thank you for fixing this bug.

Flags: needinfo?(aethanyc)
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0ad0d59dbeec
Allow a prev-in-flow to have an ExcessOverflowContainers list and merge it to our OverflowContainers as needed.  r=TYLin

Backed out for causing mochitest failures.
I backed out bug 1663222 too, but don't have permission to access it.

Backout link: https://hg.mozilla.org/integration/autoland/rev/840acfd281019cf424822376caef4806204b7203

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cpending%2Crunning%2Crunnable&revision=6de49379342e5ecf4d490510300335ed6ff49722&selectedTaskRun=FPv_RbyyQgGnkJNLKqN_Rw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=324528275&repo=autoland&lineNumber=1813

"INFO - 1 INFO TEST-START | dom/animation/test/document-timeline/test_document-timeline.html
[task 2020-12-15T03:46:21.269Z] 03:46:21 INFO - Buffered messages logged at 03:46:10
[task 2020-12-15T03:46:21.269Z] 03:46:21 INFO - 2 INFO TEST-PASS | dom/animation/test/document-timeline/test_document-timeline.html | Web Animations API: DocumentTimeline tests - Web Animations API: DocumentTimeline tests: Elided 1 passes or known failures.
[task 2020-12-15T03:46:21.269Z] 03:46:21 INFO - Buffered messages finished
[task 2020-12-15T03:46:21.270Z] 03:46:21 WARNING - 3 INFO TEST-UNEXPECTED-FAIL | dom/animation/test/document-timeline/test_document-timeline.html | document.timeline.currentTime value tests - document.timeline.currentTime value tests: assert_greater_than_equal: document.timeline.currentTime is positive or zero expected a number greater than or equal to 0 but got -1056.66
[task 2020-12-15T03:46:21.271Z] 03:46:21 INFO - 4 INFO TEST-PASS | dom/animation/test/document-timeline/test_document-timeline.html | Web Animations API: DocumentTimeline tests - Web Animations API: DocumentTimeline tests: Elided 4 passes or known failures.
[task 2020-12-15T03:46:21.271Z] 03:46:21 INFO - 5 INFO TEST-OK | dom/animation/test/document-timeline/test_document-timeline.html | took 1445ms"

Flags: needinfo?(mats)

Hmm, is the backout about layout/generic/crashtests/1670336.html causing a timeout on Android?
I don't see how test_document-timeline.html could possibly be affected by these changes.

Flags: needinfo?(mats) → needinfo?(smolnar)

Hi Mats, checked this and the document timeline failure is from another bug. I''ll reland both bugs.
We apologize for the confusion, we'll pay more attention.

Flags: needinfo?(smolnar)
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2642f290a2bf
Allow a prev-in-flow to have an ExcessOverflowContainers list and merge it to our OverflowContainers as needed.  r=TYLin CLOSED TREE

https://hg.mozilla.org/mozilla-central/rev/2642f290a2bf

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox86: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch

No worries. Thanks for re-landing.

Bugmon Analysis:
Verified bug as fixed on rev mozilla-central 20201216161026-4ae3582e3312.
Removing bugmon keyword as no further action possible.
Please review the bug and re-add the keyword for further analysis.

Status: RESOLVED → VERIFIED
status-firefox86: fixed → verified
Keywords: bugmon
status-firefox83: --- → wontfix
status-firefox84: --- → wontfix
status-firefox85: affected → wontfix
status-firefox-esr78: --- → wontfix
Flags: in-testsuite? → in-testsuite+
Blocks: 1663222
Regressions: 1703999
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: