168041 - Selecting non-ASCII characters from web page and dragging to desktop makes a clipping file with garbage contents

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Dan Gilliam]

This is another variant of bug 163908.

If you select Japanese characters from a web page and drag them to the desktop
to create a clipping file, the contents of the clipping file are garbage.

Steps to reproduce:
1. Go to http://www.yahoo.co.jp
2. Select some Japanese characters
3. Drag the selection to the desktop to create a clipping file
4. Double-click the clipping file to open it

Actual result:
Japanese characters are not displayed as garbage in the text clipping window.

Expected result:
Japanese characters are displayed correctly in the text clipping window.

Note that the filename is OK, it's just the contents that are wrong. Looks like
the fix that was applied for 163908 (adding a 'styl' resource to the clipboard
when copying) also needs to be applied for the drag-and-drop case. [Comment #7
in 163908 refers to the clipping file issue, but it didn't make it into the
Steps to Repro for that bug and so wasn't fixed at the same time, I guess]

Tested in 09/05 trunk build on Mac OS 10.1.5

Comment 1

[Mike Pinkerton (not reading bugmail)]

naoki, do you think you could get to this by Friday (9/13)? it's topembed.

Comment 2

[nhottanscp]

Not sure, I will be out tomorrow.
Let me take a look now.
ylong can you reproduce this one?

Comment 3

[Yuying Long]

Can reproduce it by following the reporter's steps with 09-11 trunk build / Mac
10.1.5.

Comment 4

[nhottanscp]

Attachment: Add 'styl' for D&D

Comment 5

[nhottanscp]

The patch adds 'sytl' for drag&drop. The conversion from Unicode to script is
performed twice because 'styl' is called as a separate flavor from 'TEXT'. I
think that is not really significant for the usual case (that is converting from
Unicode to a single script).

mike/simon, could you r/sr?

Comment 6

[Simon Fraser [no longer active]]

Ick, more cloned code between drag and drop and clipboard. It's becoming clear
that we need to factor this code better. I'll let pinkerton rule on that one.

Comment 7

[Teruko Kobayashi]

Changed QA contact to myself since this is for embedding project.

Comment 8

[saari (gone)]

adding topembed+

What's the ETA on this?

Comment 9

[Mike Pinkerton (not reading bugmail)]

Comment on attachment 98794 [details] [diff] [review]
Add 'styl' for D&D

r=pink.

yes, the clipboard and dnd classes need to share more code (like their windows
counterpart), but that's well beyond the scope of this patch.

Comment 10

[nhottanscp]

simon, could you sr?

Comment 11

[Simon Fraser [no longer active]]

Comment on attachment 98794 [details] [diff] [review]
Add 'styl' for D&D

sr=sfraser

Comment 12

[nhottanscp]

checked in to the trunk

Comment 13

[Yuying Long]

Attachment: A screen shot for accent character in clipboard with JA locale

With 09-16 trunk build / Mac 10.1.5:
1. Works fine with double byte characters on both English locale and double
byte language locale.
2. Works fine with accent characters with English locale.

3. Has problem as show in this screen shot with accent characters with Japanese
locale.

Comment 14

[Yuying Long]

Talked with Naoki, this problem in previous comment seems to be a seperete
problem (involved with keyboard layout priority), I'll file a new bug for that
later.

The original problem was fixed, and I'm marking it as verified.

Comment 15

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 98794 [details] [diff] [review]
Add 'styl' for D&D

a=[e-mail] for 1.0 branch.  Change mozilla1.0.2+ to fixed1.0.2 when
checked in

Comment 16

[Jaime Rodriguez, Jr.]

Marking as "mozilla1.0.2+" per Comment #15 From Randell Jesup. 

nhotta: Pls request EDT approval from [e-mail]

Comment 17

[nhottanscp]

Yes I did, I am waiting for the approval.

Comment 18

[Jaime Rodriguez, Jr.]

edt1.0.2+ (per verbal from saari) approval for landing on the 1.0 branch. Pls
land time asap, the replace "mozilla1.0.2+" with "fixed1.0.2". thanks!

Comment 19

[nhottanscp]

>3. Has problem as show in this screen shot with accent characters with Japanese
>locale.
filed as bug 169211

Comment 20

[nhottanscp]

checked in to 1.0 branch

Comment 21

[Teruko Kobayashi]

Verified as fixed in 09-19-05 1.0.2 MacOSX branch build.