1680440 - Remove backward compatibility code for server >70 and <=79

Status: RESOLVED FIXED

(DevTools :: General, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

See https://searchfox.org/mozilla-central/search?q=%40backward-compat+.*+version+%287%5B1-9%5D%29&path=&case=true&regexp=true

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove backward compatibility code in getNodeFrontFromNodeGrip. r=ladybenko.

Since we now always have a contentDomReference in grips, we
don't need to fallback on gripToNodeFront.
And since gripToNodeFront was only used from getNodeFrontFromNodeGrip,
we can remove it, as well as the walker actor method getNodeActorFromObjectActor.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove backward compatibility comment in paused debugger overlay. r=ladybenko.

The code isn't ready to be removed, as it depends on a Bug fix,
and not a given Firefox version.

Depends on D98720

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove backward compatibility comment for getSupportedFeatures. r=ladybenko.

The function is used, the comment was only mentioning when
the function was added, which doesn't bring us any value.

Depends on D98721

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove emitsRuleUpdatedEvent trait on the StyleRuleActor. r=ladybenko.

The trait was added in 72, so it's safe to remove it now.
With the trait removed, the onDeclarationUpdated method in rule.js
was no longer called, so we can remove it as well.

Depends on D98722

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove nullable on profiler-started activeBrowsingContextID property. r=ladybenko.

The nullable attribute was only there to handle server
older than 72, so we can remove it now.

Depends on D98723

Comment 6

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove showUserAgentShadowRoots parameter in getWalker call. r=ladybenko.

The parameter was only used for server older than 74 (newer
servers only rely on the showAllAnonymousContent param).

Depends on D98724

Comment 7

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove favicons parameter in listTabs call. r=ladybenko.

The parameter was only used for older servers, so we
can remove it now.

Depends on D98725

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove hasTabInfo trait on Tab descriptor. r=ladybenko.

The trait was added in 77, so we can safely remove it now.

Depends on D98726

Comment 9

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove getFavicon trait on Tab descriptor. r=ladybenko.

The trait was added in 76, so we can safely remove it.
This allows us to cleanup retrieveAsyncFormData, that
we rename to retrieveFavicon to better represents what it does.

Depends on D98727

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove backward compatibility code to handle older messages in legacy listeners. r=ladybenko.

Older message had a _type property and a different shape,
so we needed to transform them.
We shouldn't get those anymore since 78, so we can remove that code.

Depends on D98728

Comment 11

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove code handling missing startTime property in console evaluation response. r=ladybenko.

Depends on D98729

Comment 12

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove backward compatibility code in CombinedProgress#onProgressForWalker. r=yzen.

Older server didn't have the completed property, and we needed to rely on the
progress one. completed was added in 79, so we'll always have access to it now.

Depends on D98730

Comment 13

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove backward compatibility comment around code for deprecated tools in the Toolbox. r=jdescottes.

Since we don't have deprecated tools anymore, we can remove the code.

Depends on D98731

Comment 14

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove erroneous backward compatibility comments for goForward/goBack methods. r=ladybenko.

Those methods are used in the client, so we don't want to remove them.
The original comment was only here to indicate when it was added.

Depends on D98732

Comment 15

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove try/catch block around getPushSubscription. r=jdescottes.

The block was here to accomodate for older servers. We shouldn't
have that case anymore.

Depends on D98733

Comment 16

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Cleanup backward compatibility comments in target-mixin. r=ochameau.

Depends on D98734

Comment 17

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove backward compatibility comment for watchpoints trait in browsingContextTarget. r=ladybenko.

This trait indicates the support for watchpoints only for browsing context targets.
Other targets like worker targets don't support watchpoints, so we should keep the trait.

Depends on D98735

Comment 18

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1680440 - [devtools] Remove backward compatibility comments for descriptor watcher traits. r=jdescottes.

The watcher trait might not be set on other descriptors, so
we want to keep them until we can get rid of the generic client
code that is handling them. This can probably be done as part of Bug 1680280.

Depends on D98736

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a3923140fa86
[devtools] Remove backward compatibility code in getNodeFrontFromNodeGrip. r=ladybenko,devtools-backward-compat-reviewers.
https://hg.mozilla.org/integration/autoland/rev/135521627aea
[devtools] Remove backward compatibility comment in paused debugger overlay. r=ladybenko.
https://hg.mozilla.org/integration/autoland/rev/145ef2673b98
[devtools] Remove backward compatibility comment for getSupportedFeatures. r=ladybenko,devtools-backward-compat-reviewers.
https://hg.mozilla.org/integration/autoland/rev/bb25fc2a4c57
[devtools] Remove emitsRuleUpdatedEvent trait on the StyleRuleActor. r=ladybenko.
https://hg.mozilla.org/integration/autoland/rev/3b972c0a10cb
[devtools] Remove nullable on profiler-started activeBrowsingContextID property. r=ladybenko,devtools-backward-compat-reviewers.
https://hg.mozilla.org/integration/autoland/rev/30ed5a048844
[devtools] Remove showUserAgentShadowRoots parameter in getWalker call. r=ladybenko.
https://hg.mozilla.org/integration/autoland/rev/370cd88d70bc
[devtools] Remove favicons parameter in listTabs call. r=ladybenko,devtools-backward-compat-reviewers,jdescottes.
https://hg.mozilla.org/integration/autoland/rev/bcd19c30ed72
[devtools] Remove hasTabInfo trait on Tab descriptor. r=ladybenko.
https://hg.mozilla.org/integration/autoland/rev/da75725713df
[devtools] Remove getFavicon trait on Tab descriptor. r=ladybenko.
https://hg.mozilla.org/integration/autoland/rev/39aeb70f25d4
[devtools] Remove backward compatibility code to handle older messages in legacy listeners. r=ladybenko.
https://hg.mozilla.org/integration/autoland/rev/8fc1d7119746
[devtools] Remove code handling missing startTime property in console evaluation response. r=ladybenko.
https://hg.mozilla.org/integration/autoland/rev/be26ed8ea40c
[devtools] Remove backward compatibility code in CombinedProgress#onProgressForWalker. r=yzen.
https://hg.mozilla.org/integration/autoland/rev/1555912e791e
[devtools] Remove backward compatibility comment around code for deprecated tools in the Toolbox. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/358041ca8053
[devtools] Remove erroneous backward compatibility comments for goForward/goBack methods. r=ladybenko.
https://hg.mozilla.org/integration/autoland/rev/6755e34987d0
[devtools] Remove try/catch block around getPushSubscription. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/b93575389f4f
[devtools] Cleanup backward compatibility comments in target-mixin. r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/4fb557f04183
[devtools] Remove backward compatibility comments for descriptor watcher traits. r=jdescottes.

Comment 20

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a3923140fa86
https://hg.mozilla.org/mozilla-central/rev/135521627aea
https://hg.mozilla.org/mozilla-central/rev/145ef2673b98
https://hg.mozilla.org/mozilla-central/rev/bb25fc2a4c57
https://hg.mozilla.org/mozilla-central/rev/3b972c0a10cb
https://hg.mozilla.org/mozilla-central/rev/30ed5a048844
https://hg.mozilla.org/mozilla-central/rev/370cd88d70bc
https://hg.mozilla.org/mozilla-central/rev/bcd19c30ed72
https://hg.mozilla.org/mozilla-central/rev/da75725713df
https://hg.mozilla.org/mozilla-central/rev/39aeb70f25d4
https://hg.mozilla.org/mozilla-central/rev/8fc1d7119746
https://hg.mozilla.org/mozilla-central/rev/be26ed8ea40c
https://hg.mozilla.org/mozilla-central/rev/1555912e791e
https://hg.mozilla.org/mozilla-central/rev/358041ca8053
https://hg.mozilla.org/mozilla-central/rev/6755e34987d0
https://hg.mozilla.org/mozilla-central/rev/b93575389f4f
https://hg.mozilla.org/mozilla-central/rev/4fb557f04183