Closed Bug 1680440 Opened 2 years ago Closed 2 years ago

Remove backward compatibility code for server >70 and <=79

Categories

(DevTools :: General, task)

task

Tracking

(firefox85 fixed)

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: nchevobbe, Assigned: nchevobbe)

References

Details

Attachments

(17 files, 1 obsolete file)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

Since we now always have a contentDomReference in grips, we
don't need to fallback on gripToNodeFront.
And since gripToNodeFront was only used from getNodeFrontFromNodeGrip,
we can remove it, as well as the walker actor method getNodeActorFromObjectActor.

The code isn't ready to be removed, as it depends on a Bug fix,
and not a given Firefox version.

Depends on D98720

The function is used, the comment was only mentioning when
the function was added, which doesn't bring us any value.

Depends on D98721

The trait was added in 72, so it's safe to remove it now.
With the trait removed, the onDeclarationUpdated method in rule.js
was no longer called, so we can remove it as well.

Depends on D98722

The nullable attribute was only there to handle server
older than 72, so we can remove it now.

Depends on D98723

The parameter was only used for server older than 74 (newer
servers only rely on the showAllAnonymousContent param).

Depends on D98724

The parameter was only used for older servers, so we
can remove it now.

Depends on D98725

The trait was added in 77, so we can safely remove it now.

Depends on D98726

The trait was added in 76, so we can safely remove it.
This allows us to cleanup retrieveAsyncFormData, that
we rename to retrieveFavicon to better represents what it does.

Depends on D98727

Older message had a _type property and a different shape,
so we needed to transform them.
We shouldn't get those anymore since 78, so we can remove that code.

Depends on D98728

Older server didn't have the completed property, and we needed to rely on the
progress one. completed was added in 79, so we'll always have access to it now.

Depends on D98730

Since we don't have deprecated tools anymore, we can remove the code.

Depends on D98731

Those methods are used in the client, so we don't want to remove them.
The original comment was only here to indicate when it was added.

Depends on D98732

The block was here to accomodate for older servers. We shouldn't
have that case anymore.

Depends on D98733

This trait indicates the support for watchpoints only for browsing context targets.
Other targets like worker targets don't support watchpoints, so we should keep the trait.

Depends on D98735

The watcher trait might not be set on other descriptors, so
we want to keep them until we can get rid of the generic client
code that is handling them. This can probably be done as part of Bug 1680280.

Depends on D98736

Attachment #9191250 - Attachment description: Bug 1680440 - [devtools] Remove code handling deprecated tools in the Toolbox. r=jdescottes. → Bug 1680440 - [devtools] Remove backward compatibility comment around code for deprecated tools in the Toolbox. r=jdescottes.
Attachment #9191254 - Attachment is obsolete: true
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a3923140fa86
[devtools] Remove backward compatibility code in getNodeFrontFromNodeGrip. r=ladybenko,devtools-backward-compat-reviewers.
https://hg.mozilla.org/integration/autoland/rev/135521627aea
[devtools] Remove backward compatibility comment in paused debugger overlay. r=ladybenko.
https://hg.mozilla.org/integration/autoland/rev/145ef2673b98
[devtools] Remove backward compatibility comment for getSupportedFeatures. r=ladybenko,devtools-backward-compat-reviewers.
https://hg.mozilla.org/integration/autoland/rev/bb25fc2a4c57
[devtools] Remove emitsRuleUpdatedEvent trait on the StyleRuleActor. r=ladybenko.
https://hg.mozilla.org/integration/autoland/rev/3b972c0a10cb
[devtools] Remove nullable on profiler-started activeBrowsingContextID property. r=ladybenko,devtools-backward-compat-reviewers.
https://hg.mozilla.org/integration/autoland/rev/30ed5a048844
[devtools] Remove showUserAgentShadowRoots parameter in getWalker call. r=ladybenko.
https://hg.mozilla.org/integration/autoland/rev/370cd88d70bc
[devtools] Remove favicons parameter in listTabs call. r=ladybenko,devtools-backward-compat-reviewers,jdescottes.
https://hg.mozilla.org/integration/autoland/rev/bcd19c30ed72
[devtools] Remove hasTabInfo trait on Tab descriptor. r=ladybenko.
https://hg.mozilla.org/integration/autoland/rev/da75725713df
[devtools] Remove getFavicon trait on Tab descriptor. r=ladybenko.
https://hg.mozilla.org/integration/autoland/rev/39aeb70f25d4
[devtools] Remove backward compatibility code to handle older messages in legacy listeners. r=ladybenko.
https://hg.mozilla.org/integration/autoland/rev/8fc1d7119746
[devtools] Remove code handling missing startTime property in console evaluation response. r=ladybenko.
https://hg.mozilla.org/integration/autoland/rev/be26ed8ea40c
[devtools] Remove backward compatibility code in CombinedProgress#onProgressForWalker. r=yzen.
https://hg.mozilla.org/integration/autoland/rev/1555912e791e
[devtools] Remove backward compatibility comment around code for deprecated tools in the Toolbox. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/358041ca8053
[devtools] Remove erroneous backward compatibility comments for goForward/goBack methods. r=ladybenko.
https://hg.mozilla.org/integration/autoland/rev/6755e34987d0
[devtools] Remove try/catch block around getPushSubscription. r=jdescottes.
https://hg.mozilla.org/integration/autoland/rev/b93575389f4f
[devtools] Cleanup backward compatibility comments in target-mixin. r=ochameau.
https://hg.mozilla.org/integration/autoland/rev/4fb557f04183
[devtools] Remove backward compatibility comments for descriptor watcher traits. r=jdescottes.
You need to log in before you can comment on or make changes to this bug.