1680447 - Crash in [@ neqo_transport::crypto::CryptoDxState::encrypt]

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

7 crashes with 3+ installs during the last month. The assertion got added in https://github.com/mozilla/neqo/pull/982

Crash report: https://crash-stats.mozilla.org/report/index/9f12b00b-f400-40a8-a972-427b80201203

MOZ_CRASH Reason: assertion failed: body.len() <= 2048

Top 10 frames of crashing thread:

0 xul.dll RustMozCrash mozglue/static/rust/wrappers.cpp:16
1 xul.dll mozglue_static::panic_hook mozglue/static/rust/lib.rs:89
2 xul.dll core::ops::function::Fn::call<fn ../18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/core/src/ops/function.rs:227
3 xul.dll std::panicking::rust_panic_with_hook ../18bf6b4f01a6feaf7259ba7cdae58031af1b7b39//library/std/src/panicking.rs:573
4 xul.dll std::panicking::begin_panic::{{closure}}<str*> ../18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/panicking.rs:498
5 xul.dll std::sys_common::backtrace::__rust_end_short_backtrace<closure-0, !> ../18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/sys_common/backtrace.rs:153
6 xul.dll std::panicking::begin_panic<str*> ../18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/panicking.rs:497
7 xul.dll neqo_transport::crypto::CryptoDxState::encrypt third_party/rust/neqo-transport/src/crypto.rs:552
8 xul.dll static neqo_transport::packet::PacketBuilder::build third_party/rust/neqo-transport/src/packet/mod.rs:320
9 xul.dll neqo_transport::connection::Connection::output third_party/rust/neqo-transport/src/connection/mod.rs:1408

Comment 1

[Dragana Damjanovic [:dragana]]

This should be fixed with the last neqo update in bug 1682262.

I will leave this open for a week.

Comment 2

[Dragana Damjanovic [:dragana]]

The last neqo update has change this crash into an error. The cause of the crash has not been fixed yet.
I will close this bug and the investigation of the real cause of this bug will be perform in a separate bug. Currently this is tracked in https://github.com/mozilla/neqo/issues/1052.