1680452 - Crash in [@ swgl::swgl_fns::{{impl}}::shader_source]

Status: RESOLVED DUPLICATE of bug 1683248

(Core :: Graphics: WebRender, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

9 crashes on 5+ machines, 7/9 crashes with builds from the last 3 days, 7/9 with Fission enabled. Oldest affected build id 20201111095506.

Crash report: https://crash-stats.mozilla.org/report/index/b44c9a4e-ed0b-4f79-8635-0d2140201203

MOZ_CRASH Reason: unknown shader

Top 10 frames of crashing thread:

0 xul.dll RustMozCrash mozglue/static/rust/wrappers.cpp:16
1 xul.dll mozglue_static::panic_hook mozglue/static/rust/lib.rs:89
2 xul.dll core::ops::function::Fn::call<fn ../18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/core/src/ops/function.rs:227
3 xul.dll std::panicking::rust_panic_with_hook ../18bf6b4f01a6feaf7259ba7cdae58031af1b7b39//library/std/src/panicking.rs:573
4 xul.dll std::panicking::begin_panic::{{closure}}<str*> ../18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/panicking.rs:498
5 xul.dll std::sys_common::backtrace::__rust_end_short_backtrace<closure-0, !> ../18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/sys_common/backtrace.rs:153
6 xul.dll std::panicking::begin_panic<str*> ../18bf6b4f01a6feaf7259ba7cdae58031af1b7b39/library/std/src/panicking.rs:497
7 xul.dll swgl::swgl_fns::{{impl}}::shader_source gfx/wr/swgl/src/swgl_fns.rs:554
8 xul.dll webrender::device::gl::Device::compile_shader gfx/wr/webrender/src/device/gl.rs:1773
9 xul.dll webrender::device::gl::Device::link_program gfx/wr/webrender/src/device/gl.rs:2074

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

This seems somewhat worrying to me. It is happening in the GPU process, so that bails us out thankfully. The URLs don't yield any clues -- about:blank, about:newtab, high traffic domains, etc.

Comment 2

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

I'm able to reproduce this consistently in a fresh profile with software webrender enabled, by activating PiP on a YouTube video, e.g. https://crash-stats.mozilla.org/report/index/fb5df75c-7a55-418e-b863-edbea0201216 (edit: trimmed a 6 off the end of the URL by accident)

Comment 3

[Julien Cristau [:jcristau]]

swgl is nightly only IIRC, updating flags.

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

Looks like they are all cs_clip_rectangle_FAST_PATH.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

cs_border_solid and cs_clip_rectangle are appearing now.