Closed
Bug 1680504
Opened 4 years ago
Closed 4 years ago
Implement Runtime.exceptionThrown
Categories
(Remote Protocol :: CDP, task, P1)
Remote Protocol
CDP
Tracking
(firefox86 fixed)
RESOLVED
FIXED
86 Branch
| Tracking | Status | |
|---|---|---|
| firefox86 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [puppeteer-beta2-mvp])
Attachments
(1 file)
The event is needed by the CDP implementation of Selenium to catch thrown Javascript exceptions. It's not clear to me yet what's the difference to Log.entryAdded. I will investigate once bug 1553854 has been finished. Maybe it just duplicates code, and filters out all warning and info level messages.
|
Assignee | |
Comment 1•4 years ago
|
||
So Log.entryAdded doesn't really seem to be used. Whenever a Javascript exception is not handled the Runtime.exceptionThrown event is fired. As such I will go ahead and remove Log.entryAdded.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Priority: P2 → P1
|
|
Assignee | |
Updated•4 years ago
|
Whiteboard: [puppeteer-beta2-mvp]
|
|
Assignee | |
Comment 2•4 years ago
|
||
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7cd57b17e47f
[remote] Implement Runtime.exceptionThrown. r=remote-protocol-reviewers,jgraham
|
||
Comment 4•4 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox86:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 86 Branch
|
||
Updated•4 years ago
|
Component: CDP: Runtime → CDP
You need to log in
before you can comment on or make changes to this bug.
Description
•