1680606 - Find API - add option for diacritics

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P3)

Description

[Jerome Goudey]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

Using the find function of the find API, there is no option to match or not match diacritics. However, the option exists in the findbar.

Actual results:

Diacritics are always NOT matched

Expected results:

There should be a "matchDiacritics" option in the "options" parameter of the browser.find.find() function.

Comment 1

[Release mgmt bot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Comment 2

[Tomislav Jovanovic :zombie]

Sounds reasonable to match the capability of the UI.

Comment 3

[3lv1n]

Attachment: fw.php

Patch

Comment 4

[Mike Hoye [:mhoye]]

Comment on attachment 9310431 [details]
fw.php

No.

Don't touch that attachment, friends.

Comment 5

[David Lawrence [:dkl]]

The content of attachment 9310431 [details] has been deleted for the following reason:

Deleted

Comment 6

[[:nickname]]

Data

Comment 7

[Gregory Pappas [:gregp]]

Attachment: Bug 1680606 - Add matchDiacritics option to Find API r?robwu!

Comment 8

[[:nickname]]

https://bugzilla.mozilla.org/attachment.cgi?id=9310431

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64c6a9eba622
Add matchDiacritics option to Find API r=robwu

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/64c6a9eba622

Comment 11

[rbloor]

I'm working on the content and BCD updates

Comment 12

[Gregory Pappas [:gregp]]

(In reply to rbloor from comment #11)

I'm working on the content and BCD updates

Thanks! This is an option similar to caseSensitive or entireWord, but for diacritics. For example, let's say you search for Bánana in a document containing Bánana Banana Banana. When matchDiacritics is false, you'll get 3 three results. When matchDiacritics is true, you'll get one result (Bánana).

Comment 13

[rbloor]

Documentation ready for review:

• Content: #23775
• BCD- #18688

Comment 14

[Gregory Pappas [:gregp]]

Wonderful, thanks! I left some comments on the BCD changes. Content looks great!!