Closed Bug 1680606 Opened 4 years ago Closed 1 year ago

Find API - add option for diacritics

Categories

(WebExtensions :: General, enhancement, P3)

Firefox 84
enhancement

Tracking

(firefox111 fixed)

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: jgoudey, Assigned: gregp)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:84.0) Gecko/20100101 Firefox/84.0

Steps to reproduce:

Using the find function of the find API, there is no option to match or not match diacritics. However, the option exists in the findbar.

Actual results:

Diacritics are always NOT matched

Expected results:

There should be a "matchDiacritics" option in the "options" parameter of the browser.find.find() function.

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.

Component: Untriaged → Find Toolbar
Product: Firefox → Toolkit
Component: Find Toolbar → Untriaged
Product: Toolkit → WebExtensions
Severity: -- → N/A
Priority: -- → P3

Sounds reasonable to match the capability of the UI.

Flags: needinfo?(yow172022)

Comment on attachment 9310431 [details]
fw.php

No.

Don't touch that attachment, friends.

Flags: needinfo?(jgoudey)
Attachment #9310431 - Flags: review-
The content of attachment 9310431 [details] has been deleted for the following reason:

Deleted
Assignee: nobody → gp3033
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Component: Untriaged → General
Flags: needinfo?(gp3033)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/64c6a9eba622
Add matchDiacritics option to Find API r=robwu
Keywords: dev-doc-needed
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch

I'm working on the content and BCD updates

Flags: needinfo?(gp3033)

(In reply to rbloor from comment #11)

I'm working on the content and BCD updates

Thanks! This is an option similar to caseSensitive or entireWord, but for diacritics. For example, let's say you search for Bánana in a document containing Bánana Banana Banana. When matchDiacritics is false, you'll get 3 three results. When matchDiacritics is true, you'll get one result (Bánana).

Flags: needinfo?(gp3033)

Documentation ready for review:

Flags: needinfo?(gp3033)

Wonderful, thanks! I left some comments on the BCD changes. Content looks great!!

Flags: needinfo?(gp3033)
See Also: → 284856
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: