168064 - MRJPluginCarbon crashes if ~/Library/Logs doesn't exist

Status: VERIFIED FIXED

(Core Graveyard :: Java: OJI, defect)

Description

[Patrick C. Beard]

Now why would that never exist? If an end user doesn't have Crash Reporter
turned on for one. Doh! Patching coming up.

Comment 1

[Patrick C. Beard]

Attachment: Check JNI exceptions, create ~/Library/Logs if necessary

This patch adds additional JNI exception handling in the case that
MRJSession.open() generates an exception, and adds code to create the
directories that don't exist along the console path (i.e. ~/Library/Logs).

Comment 2

[Mike Pinkerton (not reading bugmail)]

+        if (!parentFile.exists()) {
+            parentFile.mkdirs();
+        }

could this also throw an exception that crashes?

Comment 3

[Patrick C. Beard]

Yes, that code could still throw exceptions, and the code which checks for these
exceptions is in the patch to MRJSession.cpp.

Comment 4

[Brian Nesse (gone)]

Comment on attachment 98787 [details] [diff] [review]
Check JNI exceptions, create ~/Library/Logs if necessary

r=bnesse.

Comment 5

[Simon Fraser [no longer active]]

Comment on attachment 98787 [details] [diff] [review]
Check JNI exceptions, create ~/Library/Logs if necessary

sr=sfraser

Comment 6

[Patrick C. Beard]

Fixes checked into trunk.

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 98787 [details] [diff] [review]
Check JNI exceptions, create ~/Library/Logs if necessary

a=[e-mail] for 1.0 branch checkin.  Change mozilla1.0.2+ to fixed1.0.2
when checked in

Comment 8

[Patrick C. Beard]

Fixes checked into 1.0 and chimera branches.

Comment 9

[Jaime Rodriguez, Jr.]

pmac: pls verify this as fixed on the 1.0 branch, then replace "fixed1.0.2" with
"verified1.0.2". thanks!

Comment 10

[Daniel Veditz [:dveditz]]

Patrick, should this bug be RESOLVED FIXED? Looks like you checked in

Comment 11

[Brian Nesse (gone)]

Should this land on the 1.1 branch too?

Comment 12

[Gayatri Rimola]

Please verify the bug. Once verified, change the keyword fixed1.0.2 to
verified1.0.2 

Comment 13

[Patty Mac]

Verified the patch.

Comment 14

[Patty Mac]

Verified the patch on the trunk

Comment 15

[Patty Mac]

verified.