MRJPluginCarbon crashes if ~/Library/Logs doesn't exist

VERIFIED FIXED in mozilla1.0.2

Status

Core Graveyard
Java: OJI
--
blocker
VERIFIED FIXED
16 years ago
8 years ago

People

(Reporter: Patrick C. Beard, Assigned: Patrick C. Beard)

Tracking

({crash, topembed+})

Trunk
mozilla1.0.2
PowerPC
Mac OS X
crash, topembed+

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [adt3])

Attachments

(1 attachment)

(Assignee)

Description

16 years ago
Now why would that never exist? If an end user doesn't have Crash Reporter
turned on for one. Doh! Patching coming up.
(Assignee)

Comment 1

16 years ago
Created attachment 98787 [details] [diff] [review]
Check JNI exceptions, create ~/Library/Logs if necessary

This patch adds additional JNI exception handling in the case that
MRJSession.open() generates an exception, and adds code to create the
directories that don't exist along the console path (i.e. ~/Library/Logs).
Keywords: crash, topembed
+        if (!parentFile.exists()) {
+            parentFile.mkdirs();
+        }

could this also throw an exception that crashes?
(Assignee)

Comment 3

16 years ago
Yes, that code could still throw exceptions, and the code which checks for these
exceptions is in the patch to MRJSession.cpp.
Status: NEW → ASSIGNED
Keywords: topembed → review

Comment 4

16 years ago
Comment on attachment 98787 [details] [diff] [review]
Check JNI exceptions, create ~/Library/Logs if necessary

r=bnesse.
Attachment #98787 - Flags: review+

Comment 5

16 years ago
Comment on attachment 98787 [details] [diff] [review]
Check JNI exceptions, create ~/Library/Logs if necessary

sr=sfraser
Attachment #98787 - Flags: superreview+
(Assignee)

Comment 6

16 years ago
Fixes checked into trunk.
(Assignee)

Updated

16 years ago
Keywords: review → adt1.0.1, nsbeta1, topembed
Keywords: mozilla1.0.2
Comment on attachment 98787 [details] [diff] [review]
Check JNI exceptions, create ~/Library/Logs if necessary

a=rjesup@wgate.com for 1.0 branch checkin.  Change mozilla1.0.2+ to fixed1.0.2
when checked in
Attachment #98787 - Flags: approval+

Updated

16 years ago
Keywords: mozilla1.0.2 → mozilla1.0.2+
Target Milestone: --- → mozilla1.0.2
(Assignee)

Comment 8

16 years ago
Fixes checked into 1.0 and chimera branches.
Keywords: mozilla1.0.2+ → fixed1.0.2

Updated

16 years ago
Blocks: 150046

Comment 9

16 years ago
pmac: pls verify this as fixed on the 1.0 branch, then replace "fixed1.0.2" with
"verified1.0.2". thanks!
Keywords: adt1.0.1, nsbeta1, topembed → edt1.0.2+, nsbeta1+, topembed+
Whiteboard: [adt3]
Patrick, should this bug be RESOLVED FIXED? Looks like you checked in

Comment 11

16 years ago
Should this land on the 1.1 branch too?

Comment 12

16 years ago
Please verify the bug. Once verified, change the keyword fixed1.0.2 to
verified1.0.2 

Comment 13

16 years ago
Verified the patch.
Keywords: fixed1.0.2 → verified1.0.2

Comment 14

16 years ago
Verified the patch on the trunk
Status: ASSIGNED → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED

Comment 15

16 years ago
verified.
Status: RESOLVED → VERIFIED

Updated

16 years ago
No longer blocks: 150046

Updated

8 years ago
Component: Java: OJI → Java: OJI
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.