Closed Bug 1680732 Opened 3 years ago Closed 3 years ago

Bookmark items displayed are inconsistent when show/hide Other Bookmarks and open new window

Categories

(Firefox :: Bookmarks & History, defect, P2)

Desktop
Windows 10
defect

Tracking

()

RESOLVED FIXED
85 Branch
Tracking Status
firefox85 --- fixed

People

(Reporter: alice0775, Assigned: mtigley)

References

Details

(Keywords: nightly-community)

Attachments

(2 files)

Attached image image.png

Reproducible: always when a lot of bookmarks in the bookmarks toolbar

Steps to reproduce:

  1. Hide Other Bookmarks
    --- Bug: Blank space remains
  2. Open new window
    --- may be expected
  3. Show Other Bookmarks again
    --- Bug: a bookmarks is partially Displayed

Actual Results:
See Attached screenshot

Expected Results
Blank space should not remain.
No bookmark item partially Displayed.

We should call updateNodesVisibility() on the places view when hiding/showing the other bookmarks button (like we do for resize events).

Micah, would you be able to take a look at fixing this?

Flags: needinfo?(mtigley)

(In reply to :Gijs (he/him) from comment #1)

Micah, would you be able to take a look at fixing this?

Yep, I can take a look at the fix you proposed. Thanks for the suggestion!

Flags: needinfo?(mtigley)
Assignee: nobody → mtigley
Status: NEW → ASSIGNED
Severity: -- → S3
Priority: -- → P2
Pushed by mtigley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bf1c07a76d27
Call updateNodesVisibility() from 'Show Other Bookmarks' pref observer. r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch
QA Whiteboard: [qa-85b-p2]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: