1680734 - Permafailing browser/modules/test/browser/browser_ProcessHangNotifications.js | proper number of buttons - Got 2, expected 3 when Gecko 85 merges to Beta on 2020-12-14

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Natalia Csoregi [:nataliaCs]]

Central as Beta: https://treeherder.mozilla.org/jobs?repo=try&revision=103a4c2e47f308fd1db678fa84289d50feff966f&group_state=expanded&searchStr=Linux%2C18.04%2Cx64%2CDevEdition%2Copt%2CMochitests%2Ctest-linux1804-64-devedition%2Fopt-mochitest-browser-chrome-e10s%2Cbc4&selectedTaskRun=SyBD-bh5QmWVMeli91Y_Pw.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=323577919&repo=try&lineNumber=7022

[task 2020-12-04T13:03:54.714Z] 13:03:54 INFO - TEST-PASS | browser/modules/test/browser/browser_ProcessHangNotifications.js | Notification Displayed. -
[task 2020-12-04T13:03:54.715Z] 13:03:54 INFO - Buffered messages finished
[task 2020-12-04T13:03:54.715Z] 13:03:54 INFO - TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_ProcessHangNotifications.js | proper number of buttons - Got 2, expected 3
[task 2020-12-04T13:03:54.716Z] 13:03:54 INFO - Stack trace:
[task 2020-12-04T13:03:54.716Z] 13:03:54 INFO - chrome://mochikit/content/browser-test.js:test_is:1332
[task 2020-12-04T13:03:54.716Z] 13:03:54 INFO - chrome://mochitests/content/browser/browser/modules/test/browser/browser_ProcessHangNotifications.js:terminatePluginTest:254
[task 2020-12-04T13:03:54.717Z] 13:03:54 INFO - TEST-PASS | browser/modules/test/browser/browser_ProcessHangNotifications.js | Expected the 'Stop it' button to terminate the plug-in -

:mconley, could you look at this?
Thank you.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

On it.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Looks like we only add that button for script type hangs, and not plugin hangs. That old commented out section for terminatePluginTest was probably copypaste that shouldn't have gotten carried over when that subtest was created, since it doesn't apply. Patch, with try push, coming up.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1680734 - Update browser_ProcessHangNotifications to use right button count for plugin hangs. r?Mossop!

buttonCount has a different value depending on whether or not the build is MOZ_DEV_EDITION or
not, since we show an extra Debug button for script hangs in Developer Edition.

We do not show that extra button for plugin hangs, regardless of the build type, so we
shouldn't use buttonCount here.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdbb55c9f9c1
Update browser_ProcessHangNotifications to use right button count for plugin hangs. r=mossop

Comment 5

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/fdbb55c9f9c1

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

Verified fixed in today's beta simulation.
https://treeherder.mozilla.org/jobs?repo=try&group_state=expanded&revision=e97e84bc01abddc9a0ec37bdc57f3ee2cea06a5d&searchStr=linux%2C18.04%2Cx64%2Cdevedition%2Copt%2Cmochitests%2Ctest-linux1804-64-devedition%2Fopt-mochitest-browser-chrome-e10s%2Cbc4&selectedTaskRun=WZKxStRPTAqooXc3qNqA1g.0