Closed Bug 1680780 Opened 3 years ago Closed 1 year ago

Set correct `attached` status for Targets in TargetInfo

Categories

(Remote Protocol :: CDP, enhancement, P3)

enhancement

Tracking

(firefox111 fixed)

RESOLVED FIXED
111 Branch
Tracking Status
firefox111 --- fixed

People

(Reporter: whimboo, Assigned: canadahonk)

References

Details

(Whiteboard: [puppeteer-beta2-mvp])

Attachments

(1 file)

As noticed on bug 1680740 we do not have a proper way to determine which targets are currently attached. And as such miss this property in the TargetInfo dictionary of various commands and events.

Maybe we could check if the Tab has a valid TabSession?

Lets wait for bug 1680740 so we can better test it.

No longer blocks: 1669746
Whiteboard: [puppeteer-beta2-mvp]
Priority: P2 → P3
Component: CDP: Target → CDP
Assignee: hskupin → nobody
Status: ASSIGNED → NEW

Now checks if the target is attached by going through all sessions in
the CDP connection. Also updated tests to expect new fixed behavior.

Assignee: nobody → oj
Status: NEW → ASSIGNED
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b5b90b00d80e
[cdp] Set correct attached status in TargetInfo r=webdriver-reviewers,whimboo
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 111 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: