1680836 - Cannot submit revision with empty file

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect, P2)

Description

[[ex-Mozilla] Agi Sferro | :agi]

Version 0.1.93, verified that this works correctly with 0.1.92.

Submitted this patch using mercurial: https://phabricator.services.mozilla.com/D96154?id=374991 (I later fixed the problem by downgrading to 0.1.92).

Kwan found this error:

abort: Conduit Error (ERR-CONDUIT-CORE): Uninitialized string offset: 0

Kwan also found out that the problem with the above patch is the empty file: browser/components/extensions/test/browser/serviceWorker.js.

Comment 1

[:glob ✱]

Attachment: Bug 1680836 - don't send hunks for empty files; r=zeid

Comment 2

[:glob ✱]

https://github.com/mozilla-conduit/review/commit/6af1145763cc30f8ef798fcce7d5da994a5b5c65