1680885 - Add a menu "Move PiP Toggle to Left(Right)" in context menu for the PiP toggle button

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, enhancement)

Description

[Alice0775 White]

Attachment: image.png

"Hide Picture-in-Picture Toggle" is provided.
I think it would be more convenient if there was "Move PiP Toggle to Left(Right)" menu.

Steps to reproduce:

1. Open a Video
2. Right click on the PiP toggle button

Expected Results:
The context menu is
"Hide Picture-in-Picture Toggle"
"Move PiP Toggle to Left(Right)"

Comment 1

[Rashelle]

Attachment: Bug 1680885 - Add menu item in Picture-in-Picture toggle context menu to move the toggle to the opposite side of the video. r=mtigley

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c97b17652863
Add menu item in Picture-in-Picture toggle context menu to move the toggle to the opposite side of the video. r=mtigley,fluent-reviewers,flod

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/c97b17652863

Comment 4

[Pascal Chevrel:pascalc]

Micah, is that something we should mention in our release notes? Thanks

Comment 5

[Micah [:mtigley] (she/her)]

(In reply to Pascal Chevrel:pascalc from comment #4)

Micah, is that something we should mention in our release notes? Thanks

Yes! This would be a good addition to our release notes.

Comment 6

[Pascal Chevrel:pascalc]

Could you request it through Bugzilla so as that we don't forget about it? Thanks
https://wiki.mozilla.org/Release_Management/Release_Notes#Nomination_in_Bugzilla

Comment 7

[Micah [:mtigley] (she/her)]

[Tracking Requested - why for this release]:
This change adds a new menu item to the Picture-in-Picture toggle button's context menu: "Move Picture-in-Picture Toggle to Left/Right Side". By default, the toggle button is positioned at the right side of a video element but this menu item will allow users to move it to the left side, and vice versa. This was added to allow direct user configuration of the button's positioning.

Comment 8

[Mathew Hodson]

Release Note Request (optional, but appreciated)
This change adds a new menu item to the Picture-in-Picture toggle button's context menu: "Move Picture-in-Picture Toggle to Left/Right Side". By default, the toggle button is positioned at the right side of a video element but this menu item will allow users to move it to the left side, and vice versa. This was added to allow direct user configuration of the button's positioning.

Doesn't affect Firefox for Android.

Comment 9

[Pascal Chevrel:pascalc]

Added to Firefox 95 beta release notes with this wording:

The Picture-in-Picture toggle button can now be moved to the opposite side of the video from the new context menu option Move Picture-in-Picture Toggle to Left (Right) Side.

Comment 10

[Anca Soncutean [:Anca], Desktop Release QA]

QA verified this implementation (including some exploratory testing) as part of the Beta 95 regression testing 1/3 round, platforms covered: Windows 10, Windows 7, macOS 11.0 and Ubuntu 20.
A spotcheck was performed on Nightly 96 as well, platforms covered: Windows 10, macOS 11.0 ARM , Ubuntu 21.
Our testing revealed no new issue.