Closed Bug 1680925 Opened 2 years ago Closed 2 years ago

Add Greek (el) to Release builds

Categories

(SeaMonkey :: Build Config, enhancement)

enhancement

Tracking

(seamonkey2.53+ fixed, seamonkey2.57esr? affected)

RESOLVED FIXED
seamonkey 2.83
Tracking Status
seamonkey2.53 + fixed
seamonkey2.57esr ? affected

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

Details

(Whiteboard: SM2.53.6)

Attachments

(2 files)

Greek locale is ready for future 2.53.x builds (probably 2.53.6 onwards).

Attached patch Add el patchSplinter Review

Provisional patch with relevant search plugins for 2.53.6

Attachment #9191488 - Flags: feedback?(jimspentzos2000)
Attachment #9191488 - Flags: feedback?(frgrahl)

Great! We should be able to wrap the translation process up, before 15/12/20 (due date on Pontoon).

Comment on attachment 9191488 [details] [diff] [review]
Add el patch

Builds fine. Needs an addtional backport for 2.53.6 wrt calendar but that is a different issue. In the 2.53.6b1 pre tree now.

Possible NIT Is "amazon-en-GB" to be a search engine for greek?

Attachment #9191488 - Flags: feedback?(frgrahl) → feedback+
Attached image Capture.PNG

Just an early build which we need to fine tune further to see if anything is missing because of different strings in central and 2.53.6.

chatZilla is not translated and remains en_US only in the Greek build. It is my understanding that the strings are not exposed in poonton. The directory extensions/irc is missing from el central. If this needs/should be translated we can provide a zip with files to be translated.

(In reply to Frank-Rainer Grahl (:frg) from comment #3)

Comment on attachment 9191488 [details] [diff] [review]
Add el patch

Builds fine. Needs an addtional backport for 2.53.6 wrt calendar but that is a different issue. In the 2.53.6b1 pre tree now.

Possible NIT Is "amazon-en-GB" to be a search engine for greek?

This was taken from the Firefox search engine list, is this okay Jim?

Flags: needinfo?(jimspentzos2000)

(In reply to Frank-Rainer Grahl (:frg) from comment #3)

Comment on attachment 9191488 [details] [diff] [review]
Add el patch

Builds fine. Needs an addtional backport for 2.53.6 wrt calendar but that is a different issue. In the 2.53.6b1 pre tree now.

Possible NIT Is "amazon-en-GB" to be a search engine for greek?

(In reply to Ian Neal from comment #5)

(In reply to Frank-Rainer Grahl (:frg) from comment #3)

Comment on attachment 9191488 [details] [diff] [review]
Add el patch

Builds fine. Needs an addtional backport for 2.53.6 wrt calendar but that is a different issue. In the 2.53.6b1 pre tree now.

Possible NIT Is "amazon-en-GB" to be a search engine for greek?

This was taken from the Firefox search engine list, is this okay Jim?

Yes, amazon-en-GB is fine. That's what most Greek people use.

Flags: needinfo?(jimspentzos2000)

(In reply to Frank-Rainer Grahl (:frg) from comment #4)

Created attachment 9192952 [details]
Capture.PNG

Just an early build which we need to fine tune further to see if anything is missing because of different strings in central and 2.53.6.

chatZilla is not translated and remains en_US only in the Greek build. It is my understanding that the strings are not exposed in poonton. The directory extensions/irc is missing from el central. If this needs/should be translated we can provide a zip with files to be translated.

If the extensions/irc directory contains only extension names (e.g. chatZilla), there's probably no need to translate the files. Maybe I should have a look at them, just in case. Though I am quite sure they're just fine.

If the extensions/irc directory contains only extension names (e.g. chatZilla), there's probably no need to translate the files. Maybe I should have a look at them, just in case. Though I am quite sure they're just fine.

No it contains to be translated files. cZ is technically a third party product and not translated to Greek. Basically we are the only ones left still using it for SeaMonkey. We plan to integrate it into a later release but has not happend yet. If not translated will show an English Interface and preferences. Depending on how many people will use it anyway probably not that urgent.

(In reply to Frank-Rainer Grahl (:frg) from comment #8)

If the extensions/irc directory contains only extension names (e.g. chatZilla), there's probably no need to translate the files. Maybe I should have a look at them, just in case. Though I am quite sure they're just fine.

No it contains to be translated files. cZ is technically a third party product and not translated to Greek. Basically we are the only ones left still using it for SeaMonkey. We plan to integrate it into a later release but has not happend yet. If not translated will show an English Interface and preferences. Depending on how many people will use it anyway probably not that urgent.

Oh I see. Personally, I don't think it is that urgent at the moment so, it should be OK.

Comment on attachment 9191488 [details] [diff] [review]
Add el patch

Given that anazon.co.uk is correct let finish this Bug up.

Attachment #9191488 - Flags: review+
Attachment #9191488 - Flags: approval-comm-release+
Attachment #9191488 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/0ee5e3b22228
Add Greek (el) to Release builds. r=frg

Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED

Did another test build with todays changes and I am confident we can fix remaining minor issues for 2.53.6 final at the latest.

Whiteboard: SM2.53.6
Target Milestone: --- → Future
Version: unspecified → Trunk
Attachment #9191488 - Flags: feedback?(jimspentzos2000) → feedback+
Target Milestone: Future → seamonkey 2.83
You need to log in before you can comment on or make changes to this bug.