1681026 - Enable the testPreviewNavigationCommands test in browser_preview_navigation.js

Status: RESOLVED FIXED

(Toolkit :: Printing, task, P3)

Description

[Sam Foster [:sfoster] (he/him)]

Bug 1654684 adds a mochitest to exercise the new preview navigation toolbar.
The testPreviewNavigationCommands test was causing a crash in some configurations, in automation only, so was skipped to land the feature.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Attachment: live_backing.log with details of the failure

I'm attaching a log file from running browser_preview_navigation.js with this test enabled, on linux debug on try. It has some details of the crash that fails the test.

Comment 2

[Sam Foster [:sfoster] (he/him)]

:emilio, the assert at https://searchfox.org/mozilla-central/rev/71621bfa47a371f2b1ccfd33c704913124afb933/layout/base/nsDocumentViewer.cpp#3282 is indeed off-by-one as the pageNum is 1-indexed. Once bug 1654684 lands, you can trigger this by scrolling to the end of the preview, or using the ">>" button, then clicking the ">" (next) button. That will send a "Printing:Preview:Navigate" message to the child process something like:
{pageNum = this.sheetCount, navType = nsIWebBrowserPrint.PRINTPREVIEW_GOTO_PAGENUM }

I think fixing that condition should allow us to un-skip this test. So, can you either do that when you land that fix, or let me know and I'll check and do it myself?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1681026 - Fix PrintPreviewScrollToPage assert and simplify it. r=hiro

It was off-by-one as the pages are one-indexed.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae67665f4e1e
Fix PrintPreviewScrollToPage assert and simplify it. r=hiro

Comment 5

[Sam Foster [:sfoster] (he/him)]

This bug needs another patch to enable the test before we close it

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/ae67665f4e1e

Comment 7

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1681026 - Enable the testPreviewNavigationCommands test for the print preview navigation toolbar. r?mstriemer

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9939d12eae1e
Enable the testPreviewNavigationCommands test for the print preview navigation toolbar. r=emilio

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/9939d12eae1e