Closed Bug 1681184 Opened 4 years ago Closed 4 years ago

Multistage on-boarding Importable Sites Impression telemetry getting sent twice

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

VERIFIED FIXED
85 Branch
Iteration:
85.2 - Nov 30 - Dec 13
Tracking Status
firefox85 --- verified

People

(Reporter: pdahiya, Assigned: pdahiya)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Due to race condition when Importable data call is still awaiting there is a chance <Message_Id>_SITES gets sent twice.

https://searchfox.org/mozilla-central/source/browser/components/newtab/content-src/aboutwelcome/components/MultiStageAboutWelcome.jsx#93

This doesn't impact analysis as the pings gets filtered by unique client_ids, however it will be good to fix this and reduce unused pings in Amplitude.

Assignee: nobody → pdahiya
Pushed by pdahiya@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7c01250bb480 Fix Importable Sites Impression telemetry getting sent twice r=Mardak
Severity: -- → S3
Iteration: --- → 85.2 - Nov 30 - Dec 13
Priority: -- → P1
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 85 Branch

I have verified that the "about:welcome" page telemetry pings are NOT sent twice with a local Telemetry Server using Firefox Beta 85.0b4 (Build ID: 20201220193140) on Windows 10 x64, macOS 10.15, and Ubuntu Linux 20.04 x64.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: