1681217 - Selected content document should not capture keyup event when cycling tabs by Ctrl+Tab

Status: REOPENED

(Firefox :: Tabbed Browser, defect)

Description

[Daisuke Akatsuka (:daisuke)]

Attachment: capture-keyup.html

This is a follow-up of bug 1641287.

As reported in bug 1641287#c8, during selecting a tab by Ctrl+Tab and when releases Tab or Ctrl key, the content document selecting captures the keyup event.
In this bug, we will avoid sending the keyup event.

STRs:

1. open the attached html
2. open and select about:blank page in a new tab
3. type Ctrl+Tab key

ER: The test document just will be selected.
AR: The test document is selected and captures the keyup event, then shows an alert.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1681217: Avoid sending keyup event to content document during cycling tabs.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/24d897b3cc57
Avoid sending keyup event to content document during cycling tabs. r=dao

Comment 3

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/24d897b3cc57

Comment 4

[Florencia Di Ciocco, NI to vbalducci]

Hi,
I verified this on FF 85.0a1 (2020-12-13) (64-bit). With the file from comment#0, I can't reproduce the bug. But if I use the HTML from bug 1641287#c0, I can. Are they different issues or should that be covered too?

Thanks, Flor.

Comment 5

[Daisuke Akatsuka (:daisuke)]

Hi Florencia, thank you very much for letting me know!
However, I tested this on the current Nightly 86.0a1 (2020-12-15) (64-bit) on OSX 10.14.6, could not reproduce this issue even I use the HTML from bug 1641287#c0.
I'm sorry to bother you, could you let me know the detailed STRs?

Comment 6

[Florencia Di Ciocco, NI to vbalducci]

Sure,

I saved the Html on my computer
Went to FF, opened a new tab, and loaded the HTML file (ctrl +O)
I switched to something else, like chrome or slack (alt+tab)
I returned to FF (alt+tab)
The document keyup event is captured and the page is redirected to youtube

Comment 7

[Daisuke Akatsuka (:daisuke)]

Thank you very much, Florencia!

Ah, I see.
What I fixed here was for tab selection by ctrl+tab, but it seems that the issue still remains for application selection by alt+tab.
I could reproduce this issue even with the attached HTML of this bug.
Let me fix it in another bug.

Comment 8

[Florencia Di Ciocco, NI to vbalducci]

(In reply to Daisuke Akatsuka (:daisuke) from comment #7)

What I fixed here was for tab selection by ctrl+tab, but it seems that the issue still remains for application selection by alt+tab.

Daisuke, maybe my computer is bugged or yours is bug proofed, but I just tried your method (load the file, press ctrl+tab to go to another tab, press ctrl+tab again to return to the HTML) and I still got the youtube link loaded. I'll attach a video. The profile is new and the FF version is the latest (86.0a1 (2020-12-17)). I'm on windows 10. Since this was fixed on v85, I also tested it on beta (85.0b2 (64-bit)) and got the same failed result.

Comment 9

[Florencia Di Ciocco, NI to vbalducci]

Attachment: opens youtube

Comment 10

[Daisuke Akatsuka (:daisuke)]

Attachment: windows-test.mp4

Hi Florencia, thank you very much!

I tested this on Windows 10 (but on VirtualBox), but could not reproduce the issue...
Instead, I found one different point.
I opened 3 tabs and opened the test html in a tab. Then, type Ctrl+Tab, a window for tab selection was shown, I selected from there. (If the number of tabs is 2, that window will not be shown.)
(The code is here: https://searchfox.org/mozilla-central/rev/8d722de75886d6bffc116772a1db8854e34ee6a7/browser/base/content/browser-ctrlTab.js#481-487)
However, it seems that the window was not shown in your video.
I don’t know the reason yet, do you have any idea??

Comment 11

[Florencia Di Ciocco, NI to vbalducci]

(In reply to Daisuke Akatsuka (:daisuke) from comment #10)

However, it seems that the window was not shown in your video.
I don’t know the reason yet, do you have any idea??

Because I did not hold the keys down. I pressed ctrl+tab once and let go. If I had kept them pressed down, then FF would have shown me the tab's window.

Comment 12

[Daisuke Akatsuka (:daisuke)]

Thank you very much!
I could reproduce it. Will take a look at it.

Comment 13

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1681217: Proceed keyup processing after waiting both Ctrl and Tab keyup events.

Comment 14

[Lyubomir [:mystiquewolf]]

Attachment: browser_ctrlTab.js

@Daisuke, I'm writing/editing a mochitest and the test for keyup event capture is failing every time.

The tabs involved/switched are both about:buildconfig, so i'm not sure if this exact reproduction is into the scope of this bug as they might be kind of special ones.

Nevermind i'm attaching my WIP version of the test at /mozilla-unified/browser/base/content/test/general/browser_ctrlTab.js - look at line 216.

I've tried to test with https://www.google.com/ as URL but got the error below, perhaps loading non-local URLs is not allowed during mochitest execution.

Test:browser/base/content/test/general/browser_ctrlTab.js. Minidump analysed:False. Signature:[@ mozilla::net::nsSocketTransport::InitiateSocket()]
Mozilla crash reason: MOZ_CRASH(Attempting to connect to non-local address!)

That's probably not good if it's true that only internal/built-in URLs are allowed, and internal/built-in URLs fail this test.

However take this with a grain of salt as i'm a newbie at Firefox development and for now am trying to fix just a single bug.

Note that at line 90 there's already a loaded internal tab and later ctrlTabTest is attempted, which passes - that is, when my changes are stashed away.

Comment 15

[BugBot [:suhaib / :marco/ :calixte]]

The following patch is waiting for review from a reviewer who resigned from the review:

ID	Title	Author	Reviewer Status
D100310	Bug 1681217: Proceed keyup processing after waiting both Ctrl and Tab keyup events.	daisuke	dao: Resigned from review

:daisuke, could you please find another reviewer or abandon the patch if it is no longer relevant?

For more information, please visit BugBot documentation.